Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FluxC to enable authenticated rest api requests to self-hosted sites #11522

Merged
merged 2 commits into from
Apr 9, 2020

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Mar 24, 2020

Update FluxC to allow authenticated requests. Also moves much of the logic around rest API requests out of WPAndroid to be handled within FluxC. As a result, we no longer need to rewrite the context parameter for media queries to be "view" instead of "edit" in order to avoid needing authentication.

Further details and testing instructions are in the related FluxC PR.

TODO

  • Once the FluxC PR is merged, the fluxCVersion here needs to be updated before this is merged.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 24, 2020

You can test the changes on this Pull Request by downloading the APK here.

@mchowning mchowning changed the title Update FluXc to enable authenteicated rest api requests to self-hosted sites Update FluxC to enable authenteicated rest api requests to self-hosted sites Mar 24, 2020
@mchowning mchowning force-pushed the gutenberg/authenticated_rest_api_requests branch from 2fa90a4 to 097e289 Compare March 27, 2020 20:39
@mchowning mchowning requested a review from khaykov March 30, 2020 12:44
@oguzkocer
Copy link
Contributor

Hi there! I will be freezing 14.6 in a little bit, to this PR is being bumped to 14.7. If you need this to be shipped in 14.6, please update the base branch to release/14.6 and give me a heads up when the PR is merged so I can release a new beta.

@oguzkocer oguzkocer modified the milestones: 14.6, 14.7 Apr 6, 2020
@mchowning mchowning changed the title Update FluxC to enable authenteicated rest api requests to self-hosted sites Update FluxC to enable authenticated rest api requests to self-hosted sites Apr 6, 2020
@mchowning mchowning force-pushed the gutenberg/authenticated_rest_api_requests branch from 097e289 to 1d4aa2b Compare April 6, 2020 20:47
@maxme
Copy link
Contributor

maxme commented Apr 8, 2020

❤️ +9 −234 - everything looks good on wpandroid with this patch, waiting for the new FluxC version before we can merge that one.

Screenshot 2020-04-08 at 15 57 19

@mchowning mchowning force-pushed the gutenberg/authenticated_rest_api_requests branch from 1d4aa2b to d91beb3 Compare April 8, 2020 16:34
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 8, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@mchowning
Copy link
Contributor Author

mchowning commented Apr 8, 2020

Merged the FluxC PR, tagged a beta release for FluxC, and updated the fluxCVersion here, and rebased this onto develop. I believe this PR is ready now.

@mchowning mchowning marked this pull request as ready for review April 8, 2020 16:37
Copy link
Contributor

@maxme maxme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I restarted circle ci build)

@mchowning
Copy link
Contributor Author

The "Installable build" step failure is a known issue unrelated to this PR, which is being fixed separately. Going ahead and merging this.

@mchowning mchowning merged commit c9c8c9f into develop Apr 9, 2020
@mchowning mchowning deleted the gutenberg/authenticated_rest_api_requests branch April 9, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants