-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FluxC to enable authenticated rest api requests to self-hosted sites #11522
Conversation
You can test the changes on this Pull Request by downloading the APK here. |
2fa90a4
to
097e289
Compare
Hi there! I will be freezing 14.6 in a little bit, to this PR is being bumped to 14.7. If you need this to be shipped in 14.6, please update the base branch to |
097e289
to
1d4aa2b
Compare
1d4aa2b
to
d91beb3
Compare
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Merged the FluxC PR, tagged a beta release for FluxC, and updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (I restarted circle ci build)
The "Installable build" step failure is a known issue unrelated to this PR, which is being fixed separately. Going ahead and merging this. |
Update FluxC to allow authenticated requests. Also moves much of the logic around rest API requests out of WPAndroid to be handled within FluxC. As a result, we no longer need to rewrite the context parameter for media queries to be "view" instead of "edit" in order to avoid needing authentication.
Further details and testing instructions are in the related FluxC PR.
TODO
fluxCVersion
here needs to be updated before this is merged.PR submission checklist:
RELEASE-NOTES.txt
if necessary.