Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Gutenberg dialog on new sites #11385

Merged
merged 5 commits into from
Mar 2, 2020
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -900,11 +900,6 @@ public void onClick(View v) {
if (data != null) {
int newSiteLocalID = data.getIntExtra(SitePickerActivity.KEY_LOCAL_ID, -1);
SiteUtils.enableBlockEditorOnSiteCreation(mDispatcher, mSiteStore, newSiteLocalID);
// Mark the site to show the GB popup at first editor run
SiteModel newSiteModel = mSiteStore.getSiteByLocalId(newSiteLocalID);
if (newSiteModel != null) {
AppPrefs.setShowGutenbergInfoPopupForTheNewPosts(newSiteModel.getUrl(), true);
}
}

setSite(data);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -189,10 +189,11 @@ public static void disableBlockEditor(Dispatcher dispatcher, SiteModel siteModel

public static boolean isBlockEditorDefaultForNewPost(SiteModel site) {
if (site == null) {
return false;
return true;
}
if (TextUtils.isEmpty(site.getMobileEditor())) {
return AppPrefs.isGutenbergDefaultForNewPosts();
// Default to block editor when mobile editor setting is empty
return true;
} else {
return site.getMobileEditor().equals(SiteUtils.GB_EDITOR_NAME);
}
Expand Down