-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the Gutenberg dialog on new sites #11385
Conversation
You can test the changes on this Pull Request by downloading the APK here. |
In this case, for both new and and existing users, I am still seeing the dialog. The code enabling it is here: WordPress-Android/WordPress/src/main/java/org/wordpress/android/ui/main/SitePickerActivity.java Lines 223 to 227 in d5687d5
In this case I am also still seeing the dialog. It seems to get enabled here: WordPress-Android/WordPress/src/main/java/org/wordpress/android/util/SiteUtils.java Line 118 in d5687d5
In this specific case I am not seeing the dialog. However, the first time I click on editing an existing post, the dialog does show. This is caused by code on this line. WordPress-Android/WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java Line 1408 in d5687d5
|
I think this change was made after it was pointed out,
What is unclear for me is what are the cases for non-new users that we still want to show the dialog? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the suggestions in my comment for why the test cases seem to still be showing the Gutenberg Enabled popup.
We should show the dialog only to users that we're migrating to the block editor. |
I can't reproduce that one, but it might happen due to the delay on that call after creating the site: WordPress-Android/WordPress/src/main/java/org/wordpress/android/util/SiteUtils.java Line 181 in 99065d8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, and test cases all working now. 🎉
Remove the Gutenberg dialog that was showning after creating a new site.
Also change the default for freshly added self hosted sites.
Test 1:
Test 2:
Test 3:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.