Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show retry when submit for review fails #10289

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

malinajirka
Copy link
Contributor

@malinajirka malinajirka commented Jul 26, 2019

Fixes #10288

Show "Retry" instead of "Submit" button when submitting a post for review fails.

To test:

  1. Log in as contributor
  2. Create a draft
  3. Click on Submit and turn on airplane mode before the upload finishes (you might need to change network connection strength in emulator settings)
  4. Notice the item in the post list contains "Retry" action
  5. Turn off the airplane mode and click on Retry
  6. Make sure the post gets uploaded as "Pending Review"

Update release notes:

  • The changes are too minor
Screenshot 2019-07-26 at 12 05 42 Screenshot 2019-07-26 at 12 05 12

Copy link
Member

@shiki shiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great, @malinajirka.

I found this when trying to Submit a local draft that is pending for review. The dialog is saying "The post will be published immediately". I think this is incorrect.

Android Emulator - Pixel_2_API_28:5554 2019-07-29 08-43-28

I could not find an issue related to this. Just wondering if you know?

Feel free to merge!

@malinajirka
Copy link
Contributor Author

Thank you!

I found this when trying to Submit a local draft that is pending for review. The dialog is saying "The post will be published immediately". I think this is incorrect.

Ohh, you are right. That is a weird behavior. I submitted a bug report - #10298. I wanted to fix it right away, but I wasn't sure whether we want to show a "submit confirmation" dialog or simply submit the post for review.

@malinajirka malinajirka merged commit 00c735a into develop Jul 30, 2019
@malinajirka malinajirka deleted the issue/10288-retry-submit-for-review branch July 30, 2019 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When submit for review upload fails the app should display retry button
2 participants