Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix showing wrong badge url when root path is set #3033

Merged
merged 3 commits into from
Dec 27, 2023

Conversation

andyhan
Copy link
Contributor

@andyhan andyhan commented Dec 27, 2023

Fix #3032

@qwerty287 qwerty287 added this to the 2.2.0 milestone Dec 27, 2023
@qwerty287 qwerty287 added bug Something isn't working ui frontend related labels Dec 27, 2023
6543
6543 previously requested changes Dec 27, 2023
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per @qwerty287

@6543 6543 changed the title Fix Wrong badgeUrl repo badge tab when rootPath is not empty. #3032 Fix Wrong badgeUrl repo badge tab when rootPath is not empty Dec 27, 2023
@6543 6543 merged commit 8c4480f into woodpecker-ci:main Dec 27, 2023
6 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 27, 2023
1 task
@anbraten anbraten changed the title Fix Wrong badgeUrl repo badge tab when rootPath is not empty Fix showing wrong badge url when root path is set Dec 27, 2023
6543 pushed a commit that referenced this pull request Dec 27, 2023
This PR was opened by the
[ready-release-go](https://github.com/woodpecker-ci/plugin-ready-release-go)
plugin. When you're ready to do a release, you can merge this
pull-request and a new release with version `2.1.1` will be created
automatically. If you're not ready to do a release yet, that's fine,
whenever you add more changes to `main` this pull-request will be
updated.

## Options

- [ ] Mark this version as a release candidate

##
[2.1.1](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.1.1)
- 2023-12-27

### 🐛 Bug Fixes

- trim v on version check
[[#3039](#3039)]
- make backend step dag generation deterministic
[[#3037](#3037)]
- Fix showing wrong badge url when root path is set
[[#3033](#3033)]
- Fix docs label
[[#3028](#3028)]

### 📚 Documentation

- Update go report card badge
[[#3029](#3029)]

### Misc

- Add some tests
[[#3030](#3030)]
@6543 6543 modified the milestones: 2.2.0, 2.1.1 Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui frontend related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong badgeUrl when rootPath is not empty in the page of repo badge settings
3 participants