-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix showing wrong badge url when root path is set #3033
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwerty287
reviewed
Dec 27, 2023
6543
approved these changes
Dec 27, 2023
6543
previously requested changes
Dec 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per @qwerty287
qwerty287
approved these changes
Dec 27, 2023
6543
changed the title
Fix Wrong badgeUrl repo badge tab when rootPath is not empty. #3032
Fix Wrong badgeUrl repo badge tab when rootPath is not empty
Dec 27, 2023
anbraten
changed the title
Fix Wrong badgeUrl repo badge tab when rootPath is not empty
Fix showing wrong badge url when root path is set
Dec 27, 2023
6543
pushed a commit
that referenced
this pull request
Dec 27, 2023
This PR was opened by the [ready-release-go](https://github.com/woodpecker-ci/plugin-ready-release-go) plugin. When you're ready to do a release, you can merge this pull-request and a new release with version `2.1.1` will be created automatically. If you're not ready to do a release yet, that's fine, whenever you add more changes to `main` this pull-request will be updated. ## Options - [ ] Mark this version as a release candidate ## [2.1.1](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.1.1) - 2023-12-27 ### 🐛 Bug Fixes - trim v on version check [[#3039](#3039)] - make backend step dag generation deterministic [[#3037](#3037)] - Fix showing wrong badge url when root path is set [[#3033](#3033)] - Fix docs label [[#3028](#3028)] ### 📚 Documentation - Update go report card badge [[#3029](#3029)] ### Misc - Add some tests [[#3030](#3030)]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3032