make backend step dag generation deterministic #3037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS: I'll push 100% pass once test failed |
|
Would it be possible to keep order defined in the pipeline definition? |
|
@lafriks yes - done |
lafriks
approved these changes
Dec 27, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3037 +/- ##
==========================================
- Coverage 35.80% 34.85% -0.96%
==========================================
Files 221 227 +6
Lines 14175 14767 +592
==========================================
+ Hits 5076 5147 +71
- Misses 8719 9240 +521
Partials 380 380 ☔ View full report in Codecov by Sentry. |
6543
added
bug
6543
pushed a commit
that referenced
this pull request
Dec 27, 2023
This PR was opened by the [ready-release-go](https://github.com/woodpecker-ci/plugin-ready-release-go) plugin. When you're ready to do a release, you can merge this pull-request and a new release with version `2.1.1` will be created automatically. If you're not ready to do a release yet, that's fine, whenever you add more changes to `main` this pull-request will be updated. ## Options - [ ] Mark this version as a release candidate ## [2.1.1](https://github.com/woodpecker-ci/woodpecker/releases/tag/2.1.1) - 2023-12-27 ### 🐛 Bug Fixes - trim v on version check [[#3039](#3039)] - make backend step dag generation deterministic [[#3037](#3037)] - Fix showing wrong badge url when root path is set [[#3033](#3033)] - Fix docs label [[#3028](#3028)] ### 📚 Documentation - Update go report card badge [[#3029](#3029)] ### Misc - Add some tests [[#3030](#3030)]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the the generation for backend steps if a dag is used deterministic.
this also fix where the test randomly fail like in: