-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appearance > Menu > Product Categories tab sub-menus bug #13040
Comments
i can confirm that if i switch my category Swordtails that is the last one in the list button #1 with Tetras thats in list #2 then tetra shows in the right place but then Swordtails goes to list #2 and is not showing at the right place in the tree so im thinking there is a code error when the list gets to big and it starts showing 1,2,3,4 buttons to show the rest of the category. |
is there a way to tern off the code that splits the list of the 1,2,3, buttons in Appearance > menu > Product Categories tab so it all shows in one list so i can see if it fixes it ? |
It looks like the problem has to do with the nesting / child categories. The second page starts with the categories that are top-level and their children. Then at the end it has the miscellaneous categories whose parents are on page 1. |
^ this. But it's not something we should be fixing as it's generated and rendered by WP core (all hierarchical categories output in the same way). We don't control that code. Try the search - it's easier than browsing through pages. |
so should i open a issue with WP core ? |
^ @justinshreve can you double check my logic above? Should we raise it? |
If that's broken because of WP core's handling (looks like it is), yeah I think we should raise it. If that's a wontfix on their end or it's going to be awhile,maybe there something we could do with a hook or filter? Push the search as the first tab for example? I did a brief look but didn't see if that was possible or not. |
so do i need to open a bug with WP or are you guys going to do it ? |
bump |
I think if you can reproduce it with regular post categories with as simple as an example as possible, you can log. Post the link here and we can watch, bump, or fix (if I get a chance) :) |
@mikejolley @justinshreve i did reproduce this bug on WP using regular post categories. |
@mikejolley @justinshreve i opened a WP ticket here please add some comments so they can fix this. i did my best to explain the bug. |
@mikejolley @justinshreve can you please confirm this bug with Welcher (Component Maintainer) at https://core.trac.wordpress.org/ticket/40827#comment:3 |
still waiting for a reply from the WP core team at : https://core.trac.wordpress.org/ticket/40827 i don't know if you can ask them if they are going to fix this prob? i mean it's almost been 3 months. Do you think you guys could find a way to fix this as WP core don't seem to be willing to fix the bug. let's say the more i add products and category the more this bug is messing up my tree... |
ok, i just got a reply from WP ... turns out this bug has been known for over 6 years. WP never did fix it as you can see here: https://core.trac.wordpress.org/ticket/18282 Some say: the issue will be resolved when... someone takes the time to resolve it. They say some one did a temp patch that we need to manually do for the time being ... but im wondering if its safe to use with WC. The manual patch seems to works by eliminating pagination under 'View All' The code to this temp patch is here: https://core.trac.wordpress.org/attachment/ticket/18282/preserve-page-and-taxonomy-hierarchy.php There are other comments there with ideas of how to fix it but no one did take the time to fixing the bug for good. Seems like this is just not going to get fixed by WP anytime soon... maybe if you add to that ticket that its affecting woocommerce maybe then they could start looking for a fix seeing as is affecting many ppl just look at their ticket there is over 40 comments there. Maby it would be best for WC to fix this bug if you can since this bug is affecting WC. |
If we were going to spend the time to fix or workaround this in WC, we'd commit a fix to WP. It's not a high priority. |
with all the category I have in WP and products it's getting to a point where it's getting really hard to use because of this bug. Can you guys at least consider fixing it? or at least say WC is not meant to have a big inventory of category with products nested. My point is if this is not going to fix il need to spend a lot of hours and months to transfer all my E-shops to an other platform and there are some costs associated with this too. I love WP but this bug is getting to a point where it's hard to use, not to mention all the WP plugins i have purchased that il need to re-purchase for an another platform. Can't this be fixed with a hook or filter as @justinshreve has said here: i would fix this if i would be a programmer but im not :( i need guys like you to help. sorry if I'm irritated with this bug but im facing this bug every day when working with WP. |
@raykai there are other ways to use categories than in menus. You could for example use regular URLs/links to add categories to menus. Surely thats easier than digging around multiple pages looking for what you want? Or even outputting categories programmatically in the template. |
how would i go about outputting categories programmatically in the template? this would save me a lot of time. |
https://developer.wordpress.org/reference/functions/wp_list_categories/ with taxonomy |
I've just submitted a workaround for this problem on the WordPress Trac: https://core.trac.wordpress.org/ticket/18282#comment:51 It should disable the pagination on these menu meta boxes, I hope it works for you! (And let me know if I missed anything with it) |
@danburzo do we add this as a plugin? where do we put this code? |
This is a big problem when using WordPress with Woocommerce. Sometimes I have the same name under different categories. Since this messed up hierarchy I can't distinguish what belongs to what category. Really appreciate if someone can solve this issue. |
@raykai @amilabandara you can add the code in your add_filter( 'nav_menu_meta_box_object', 'disable_pagination_in_menu_meta_box', 9 );
function disable_pagination_in_menu_meta_box($obj) {
$obj->_default_query = array(
'posts_per_page' => -1
);
return $obj;
} (It's a problem in WordPress, not WooCommerce) |
Hey @danburzo it doesn't work. I have it on my functions.php and the pagination still appears. Do you know if it is maybe because core changed? |
@kevinmamaqi I’m not sure and unfortunately I won’t be around my laptop soon. Maybe someone can confirm this? What version of WordPress are you using? |
i am aslo facing this problems. it's really a bad experience. i got sick of it. |
Less of a fix and more just avoiding the issue at that point. Works only to a degree due to scaling concerns. Also, no need to edit the code. There is a setting for this: http://cld.wthms.co/D6vvUO |
Im facing the same problem, where i cab subcategories with the same names so its imposible to distinguish al. At the moment im just using customs links so i suggest to use that while this problems is fixed, i dont like to try fix problems in case i mess another thing. Just wait 6 years more till fixed ... |
28-Aug-2018
Appreciate your solution - ed0522" and thank you very much. |
you r great that helped me alot |
many many thanks....you saved my life :) |
Hi, |
Great, thanks now it’s work :D
… Il giorno 17 lug 2019, alle ore 16:21, vitorw3 ***@***.***> ha scritto:
I've just submitted a workaround for this problem on the WordPress Trac: https://core.trac.wordpress.org/ticket/18282#comment:51 <https://core.trac.wordpress.org/ticket/18282#comment:51>
It should disable the pagination on these menu meta boxes, I hope it works for you! (And let me know if I missed anything with it)
Para mim funcionou perfeito esta solução abaixo. Criei o plugin através o aquivo disponibilizado no core do WP e instalei normalmente. Fez com que retirasse a paginação dita no problema, mantendo assim a hierarquia.
Mensagem da solução do problema no link passado por nosso amigo danburzo:
by @baroninn <https://github.com/baroninn>
I had the same issue,
Tried all kinds of solutions.
The one that worked for me was to download this plugin and activate
https://core.trac.wordpress.org/attachment/ticket/18282/preserve-page-and-taxonomy-hierarchy.php <https://core.trac.wordpress.org/attachment/ticket/18282/preserve-page-and-taxonomy-hierarchy.php>
You can see the download button at the bottom of the page.
You then need to create a folder in your plugins folder and place this file in there.
Everything was perfect for me after that.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#13040?email_source=notifications&email_token=AMSQLXVEJ4AKHEDWANFHN33P74TFFA5CNFSM4C6NXKFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2ELONA#issuecomment-512276276>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMSQLXXWMH2TLDC4AZDDN6TP74TFFANCNFSM4C6NXKFA>.
|
glad my solution is helping people :-) |
Thank you so much, you're a lifesaver. |
Hi, |
Hi,
add this to your function on the child
function disable_pagination_in_menu_meta_box($obj) {
$obj->_default_query = array(
'posts_per_page' => -1
);
return $obj;
}
I have wp 5.1.2 and is ok, I hope that works for you too.
… Il giorno 6 ott 2019, alle ore 15:00, loremgit ***@***.***> ha scritto:
Hi,
does't work for for me, with the last wp version (5.1.1) the $per_page is on line 338 I've tried to change to 5000 and than 300 but nothing change I still have pagination on the category product menu section.
Somebody can help me?
Thanks in advance ;)
Hi,
It's line 659 in 5.2.3 and yes it works like a charm.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#13040?email_source=notifications&email_token=AMSQLXVUOMAD4ZIBO5EJROLQNHOQXA5CNFSM4C6NXKFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAOJRDY#issuecomment-538744975>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMSQLXTV32ZVISN7GWFEQ2TQNHOQXANCNFSM4C6NXKFA>.
|
actually there is two in case anyone try the solution above and doesnt work, make sure its commented for objects, not for post object. this workaround saves me! |
hello |
Hi, you have to add the code in the function.php of your child them, if you don’t have a child you need to create it at first.
Regards
… Il giorno 23 nov 2019, alle ore 21:06, liamc96-dotcom ***@***.***> ha scritto:
hello
how to i change this code in theme editor
please help
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#13040?email_source=notifications&email_token=AMSQLXQIU2LUYTLZIM47CI3QVGEL7A5CNFSM4C6NXKFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE74VVI#issuecomment-557828821>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMSQLXTYPRHIOUGWNGXUCPDQVGEL7ANCNFSM4C6NXKFA>.
|
Thank you
Regards,
Liam Corry.
… On 25 Nov 2019, at 10:01 am, Machaddict ***@***.***> wrote:
Hi, you have to add the code in the function.php of your child them, if you don’t have a child you need to create it at first.
Regards
> Il giorno 23 nov 2019, alle ore 21:06, liamc96-dotcom ***@***.***> ha scritto:
>
> hello
> how to i change this code in theme editor
> please help
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub <#13040?email_source=notifications&email_token=AMSQLXQIU2LUYTLZIM47CI3QVGEL7A5CNFSM4C6NXKFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE74VVI#issuecomment-557828821>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMSQLXTYPRHIOUGWNGXUCPDQVGEL7ANCNFSM4C6NXKFA>.
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
it's working on WP 5.3 |
I can not find this text "Paginate browsing for large numbers of objects" |
I don't recommend changing core wordpress files. |
That is correct.But if you creat a child theme it will overwrite from those files.
Regards,
Liam Corry.
… On 18 May 2020, at 5:45 pm, baroninn ***@***.***> wrote:
I don't recommend changing core wordpress files.
they will be overwritten in upcoming updates.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
so what is the solution? |
This issue should not be closed. The only solution seems to be hacking within Wordpress ADMIN's nav php file which is a big no no. |
I have experienced this issue without WooCommerce. Using the fixes above, it corrected the problem of the Appearance menu categories but in the Gutenberg editor the problem persists with a number of terms not showing. My taxonomy is; 13 regions and around 240 country terms. It drops items starting in Africa and reflects A-G countries only shows a few from other regions. Regions
Any thoughts there? |
I still get this issue in 2020! The above solution worked perfectly. Thank you for sharing! |
Hello, I am also still having this issue in 2020. The above posted solutions didn't work for me. Well, the Preserve Page and Taxonomy Hierarchy plugin worked for showing the hierarchy finally, but I can't add all the categories to my menu, because it doesn't show all of them (I have a LOT of categories). I also can not find this text "Paginate browsing for large numbers of objects" or the line "$per_page" in the nav-menu.php file... And also adding this: function disable_pagination_in_menu_meta_box($obj) { to my child functions.php didn't work either. Could someone please help me? |
Same issue on September 3rd 2020, I try everything, nothing works :-( What is the new procedure with the last version of Wordpress 5.5.1 |
Working, using it now 10/26/2020 Wordpress version: 5.4.2 |
Man I can't thank you more...I spent a whole day to resolve this issue and this worked |
Bro i only created an account to thank you.. |
Yay, there's a solution! Been pulling my hair out over this and finally stumbled on this thread. WP repository has a plugin called Preserve Hierarchy Taxonomy by Amin Nazemi and so far so good! If I had 50 categories (in this case it's WooCommerce cats and sub-cats), the menu tree displays properly when I'm creating my menu. Add one or more and the whole hierarchy list breaks. Not sure if this is the same plugin as referenced above, but was the only one I could find. And. It. Works. |
same issue in wp 6.2.2 |
EXPLANATION OF THE ISSUE
in admin back end > Appearance > Menu > Product Categories tab
if you have a lot of Product Categories you will have a 1,2,3 button to show the rest of the categories
the 1st button # 1 tree works well showing all sub categories exactly like in [admin back end > Products > Categories] but when you get the tab #2 to show the rest of the categories its all messed up not showing the sub lines or the right categories in the right order...
see screenshots :
woocommerce Product Categories tree.jpg is my Product Categories page:
tab 1ok.jpg is the Menu > Product Categories tab button #1 where all works as it should
tab2bug.jpg is the Menu > Product Categories tab button #2 where it starts to mess up my product categories and sub categories tree
i hope there is a way to fix it.
STEPS TO REPRODUCE THE ISSUE
just create many Product Categories till u have at-least a button tab #2
SYSTEM STATUS REPORT
`
WordPress Environment
Home URL: https://www.aquaexotik.ca
Site URL: https://www.aquaexotik.ca
WC Version: 2.6.13
Log Directory Writable: ✔
WP Version: 4.7.2
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: –
WP Cron: ✔
Language: en_US
Server Environment
Server Info: Apache
PHP Version: 7.0.15
PHP Post Max Size: 16 MB
PHP Time Limit: 120
PHP Max Input Vars: 1000
cURL Version: 7.47.0
OpenSSL/1.0.2g
SUHOSIN Installed: –
MySQL Version: 5.7.17
Max Upload Size: 16 MB
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
GZip: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔
Database
WC Database Version: 2.6.13
:
woocommerce_sessions: ✔
woocommerce_api_keys: ✔
woocommerce_attribute_taxonomies: ✔
woocommerce_downloadable_product_permissions: ✔
woocommerce_order_items: ✔
woocommerce_order_itemmeta: ✔
woocommerce_tax_rates: ✔
woocommerce_tax_rate_locations: ✔
woocommerce_shipping_zones: ✔
woocommerce_shipping_zone_locations: ✔
woocommerce_shipping_zone_methods: ✔
woocommerce_payment_tokens: ✔
woocommerce_payment_tokenmeta: ✔
MaxMind GeoIP Database: ❌ The MaxMind GeoIP Database does not exist - Geolocation will not function. You can download and install it manually from http://dev.maxmind.com/geoip/legacy/geolite/ to the path: . Scroll down to "Downloads" and download the "Binary / gzip" file next to "GeoLite Country"
Active Plugins (46)
Ultimate Addons for Visual Composer: by Brainstorm Force – 3.16.7
HTML in Category Descriptions: by Arno Esterhuizen – 1.2.1.1
Activity Log: by Yakir Sitbon
Maor Chasen
Ariel Klikstein – 2.3.4
Cloudflare: by John Wineman
Furkan Yilmaz
Junade Ali (Cloudflare Team) – 3.1.1
Contact Form 7 Controls: by Kaspars Dambis – 0.3.4
Contact Form 7: by Takayuki Miyoshi – 4.6.1
Dynamic Featured Image: by Ankit Pokhrel – 3.5.2
Enable Media Replace: by Måns Jonasson – 3.0.5
Enhanced Media Library: by wpUXsolutions – 2.4.3
Google Analytics Dashboard for WP: by Alin Marcu – 4.9.6
iframe: by webvitaly – 4.3
Invisible reCaptcha: by Mihai Chelaru – 1.0.3
WPBakery Visual Composer: by Michael M - WPBakery.com – 5.0.1
Key4ce osTicket Bridge: by Key4ce – 1.4.0
Media Files Tool: by j.conti – 1.2.1
Menu In Menu: by Roger Barrett – 1.0.0
MouseWheel Smooth Scroll: by Jakub Novák – 2.4
Nav Menu Roles: by Kathy Darling – 1.8.6
Ultimate Nofollow: by bitacre – 1.4.5
Porto Content Types: by SW-THEMES – 1.3
Porto Shortcodes: by SW-THEMES – 1.6.3
Porto Widgets: by SW-THEMES – 1.3.1
Really Simple CAPTCHA: by Takayuki Miyoshi – 1.9
Regenerate Thumbnails: by Alex Mills (Viper007Bond) – 2.2.6
Remove Widget Titles: by Stephen Cronin – 1.0
Slider Revolution: by ThemePunch – 5.3.1.5
Rich Text Tags, Categories, and Taxonomies: by Katz Web Services
Inc. – 1.8
Simple History: by Pär Thernström – 2.13
WPML Multilingual CMS: by OnTheGoSystems – 3.6.3
WooCommerce Multilingual: by OnTheGoSystems – 4.0.4
WooCommerce PDF Invoices & Packing Slips: by Ewout Fernhout – 1.5.38
WooCommerce: by WooThemes – 2.6.13
Wordfence Security: by Wordfence – 6.3.0
WP Mail Logging: by Christian Zöller – 1.7.0
WP Maintenance Mode: by Designmodo – 2.0.9
WP Sitemap Page: by Tony Archambeau – 1.6
WordPress w3all phpBB integration: by axew3 – 1.5.9
WPML CMS Nav: by OnTheGoSystems – 1.4.19
WPML Media: by OnTheGoSystems – 2.1.24
WPML Sticky Links: by OnTheGoSystems – 1.4.0
WPML String Translation: by OnTheGoSystems – 2.5.2
WPML Translation Management: by OnTheGoSystems – 2.2.7
WPML Widgets: by Jeroen Sormani – 1.0.6
YITH WooCommerce Ajax Product Filter: by YITHEMES – 3.1.2
YITH WooCommerce Ajax Search: by YITHEMES – 1.4.1
YITH WooCommerce Wishlist: by YITHEMES – 2.0.16
Settings
Force SSL: ✔
Currency: CAD ($)
Currency Position: left
Thousand Separator: ,
Decimal Separator: .
Number of Decimals: 2
API
API Enabled: ✔
WC Pages
Shop Base: #10 - /shop/
Cart: #11 - /cart/
Checkout: #12 - /checkout/
My Account: #13 - /my-account/
Taxonomies
Product Types: external (external)
grouped (grouped)
simple (simple)
variable (variable)
Theme
Name: Porto Child
Version: 1.1
Author URL: http://newsmartwave.net/
Child Theme: ✔
Parent Theme Name: Porto
Parent Theme Version: 3.4
Parent Theme Author URL: http://www.newsmartwave.net/
WooCommerce Support: ✔
Templates
Overrides: porto/woocommerce/archive-product.php
porto/woocommerce/cart/cart-shipping.php
porto/woocommerce/cart/cart-totals.php
porto/woocommerce/cart/cart.php
porto/woocommerce/cart/cross-sells.php
porto/woocommerce/cart/mini-cart.php
porto/woocommerce/cart/shipping-calculator.php
porto/woocommerce/checkout/form-checkout.php
porto/woocommerce/checkout/form-coupon.php
porto/woocommerce/checkout/form-login.php
porto/woocommerce/checkout/form-pay.php
porto/woocommerce/checkout/payment.php
porto/woocommerce/checkout/review-order.php
porto/woocommerce/content-product.php
porto/woocommerce/content-product_cat.php
porto/woocommerce/content-single-product.php
porto/woocommerce/content-widget-product.php
porto/woocommerce/global/form-login.php
porto/woocommerce/global/quantity-input.php
porto/woocommerce/loop/add-to-cart.php
porto/woocommerce/loop/loop-end.php
porto/woocommerce/loop/loop-start.php
porto/woocommerce/loop/no-products-found.php
porto/woocommerce/loop/orderby.php
porto/woocommerce/loop/pagination.php
porto/woocommerce/loop/rating.php
porto/woocommerce/loop/sale-flash.php
porto/woocommerce/myaccount/downloads.php
porto/woocommerce/myaccount/form-add-payment-method.php
porto/woocommerce/myaccount/form-edit-account.php
porto/woocommerce/myaccount/form-edit-address.php
porto/woocommerce/myaccount/form-login.php
porto/woocommerce/myaccount/form-lost-password.php
porto/woocommerce/myaccount/form-reset-password.php
porto/woocommerce/myaccount/lost-password-confirmation.php
porto/woocommerce/myaccount/my-account.php
porto/woocommerce/myaccount/my-address.php
porto/woocommerce/myaccount/my-downloads.php
porto/woocommerce/myaccount/my-orders.php
porto/woocommerce/myaccount/orders.php
porto/woocommerce/myaccount/payment-methods.php
porto/woocommerce/myaccount/view-order.php
porto/woocommerce/order/form-tracking.php
porto/woocommerce/order/order-details.php
porto/woocommerce/order/tracking.php
porto/woocommerce/single-product/add-to-cart/external.php
porto/woocommerce/single-product/add-to-cart/grouped.php
porto/woocommerce/single-product/add-to-cart/simple.php
porto/woocommerce/single-product/add-to-cart/variable.php
porto/woocommerce/single-product/meta.php
porto/woocommerce/single-product/product-attributes.php
porto/woocommerce/single-product/product-image.php
porto/woocommerce/single-product/product-thumbnails.php
porto/woocommerce/single-product/rating.php
porto/woocommerce/single-product/related.php
porto/woocommerce/single-product/review-meta.php
porto/woocommerce/single-product/review-rating.php
porto/woocommerce/single-product/review.php
porto/woocommerce/single-product/sale-flash.php
porto/woocommerce/single-product/share.php
porto/woocommerce/single-product/short-description.php
porto/woocommerce/single-product/tabs/tabs.php
porto/woocommerce/single-product/title.php
porto/woocommerce/single-product/up-sells.php
porto/woocommerce/single-product-reviews.php
`
The text was updated successfully, but these errors were encountered: