Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

line-height in h1 - email notification #1

Closed
NiklasHogefjord opened this issue Sep 12, 2011 · 0 comments
Closed

line-height in h1 - email notification #1

NiklasHogefjord opened this issue Sep 12, 2011 · 0 comments
Assignees
@jameskoster

Comments

@NiklasHogefjord
Copy link

The line-height in the email notification h1 should be increased. It's not a big issue. When WooCommerce sends out a new order email the problem doesn't occur because the title stays on one line, but I use a debug feature in the Payson gateway and the title gets longer. When it spills over on a second line the text overlaps.
@ghost ghost assigned jameskoster Sep 13, 2011
@kingbt kingbt mentioned this issue Sep 10, 2012
Closed
@gobnet14 gobnet14 mentioned this issue Oct 2, 2012
Closed
mikejolley pushed a commit that referenced this issue Nov 22, 2012
Merge pull request #1 from woothemes/master
04d4101 
update fork
mikejolley pushed a commit that referenced this issue Dec 4, 2012
@KingYes
Merge pull request #1 from woothemes/master
75c37ed 
sync
@edwinhamers edwinhamers mentioned this issue Feb 9, 2013
Closed
@kapitaine kapitaine mentioned this issue Feb 21, 2013
Closed
coenjacobs pushed a commit that referenced this issue Jan 8, 2014
Merge pull request #1 from woothemes/master
1398142 
update test
ChromeOrange added a commit that referenced this issue Feb 25, 2014
@ChromeOrange
Merge pull request #1 from woothemes/master
5d43b6c 
Update
mikejolley pushed a commit that referenced this issue Mar 12, 2014
@jmotes
Merge pull request #1 from jmotes/patch-1
e754c2e 
Fix for #5106 - allow checkout in older IE
ChromeOrange added a commit that referenced this issue Mar 31, 2014
@ChromeOrange
Merge pull request #1 from woothemes/master
0ada403 
Update
mikejolley pushed a commit that referenced this issue May 22, 2014
@lukecarbis
Merge pull request #1 from woothemes/master
cdb1e61 
Merge woothemes latest.
mikejolley pushed a commit that referenced this issue May 22, 2014
@y12studio
Merge pull request #1 from woothemes/master
1f6f7d3 
Update
@bryceadams bryceadams mentioned this issue Aug 1, 2014
Closed
mikejolley pushed a commit that referenced this issue Aug 26, 2014
@shivapoudel
Merge pull request #1 from woothemes/master
0143114 
Updated WooComerce
mikejolley pushed a commit that referenced this issue Sep 22, 2014
@joshlevinson
Merge pull request #1 from woothemes/master
4369784 
Update to WC original
@Tigersden Tigersden mentioned this issue Oct 1, 2014
Closed
@oppgroup oppgroup mentioned this issue Oct 10, 2014
Closed
claudiosanches added a commit that referenced this issue Oct 11, 2014
@claudiosanches
Prevented warnings when countries is empty in shipping methods.
86ef099 
Stopped this erros:

PHP Warning:  array_intersect(): Argument #1 is not an array in
wp-content/plugins/woocommerce/includes/abstracts/abstract-wc-shipping-method.php
on line 182
PHP Warning:  in_array() expects parameter 2 to be array, null given in
wp-content/plugins/woocommerce/includes/abstracts/abstract-wc-shipping-method.php
on line 194

@mikejolley
claudiosanches added a commit that referenced this issue Oct 11, 2014
@claudiosanches
Prevented warnings when countries is empty in shipping methods.
9f74996 
Stopped this erros:

PHP Warning:  array_intersect(): Argument #1 is not an array in
wp-content/plugins/woocommerce/includes/abstracts/abstract-wc-shipping-method.php
on line 182
PHP Warning:  in_array() expects parameter 2 to be array, null given in
wp-content/plugins/woocommerce/includes/abstracts/abstract-wc-shipping-method.php
on line 194
claudiosanches added a commit that referenced this issue Oct 21, 2014
@claudiosanches @mikejolley
Prevented warnings when countries is empty in shipping methods.
477a932 
Stopped this erros:

PHP Warning:  array_intersect(): Argument #1 is not an array in
wp-content/plugins/woocommerce/includes/abstracts/abstract-wc-shipping-method.php
on line 182
PHP Warning:  in_array() expects parameter 2 to be array, null given in
wp-content/plugins/woocommerce/includes/abstracts/abstract-wc-shipping-method.php
on line 194

@mikejolley
@mclamee mclamee mentioned this issue Jan 13, 2015
Closed
This was referenced Mar 25, 2015
Closed
Closed
@PetterRuud PetterRuud mentioned this issue Jul 31, 2015
Closed
SiR-DanieL added a commit that referenced this issue Aug 6, 2015
@SiR-DanieL
Merge pull request #1 from MarinaWoo/patch-1
3ae67c9 
Typos, phrasing and grammar edits
@MarioKnight MarioKnight mentioned this issue Aug 11, 2015
Closed
@janiszalitis janiszalitis mentioned this issue Aug 27, 2015
Closed
mikejolley pushed a commit that referenced this issue Sep 8, 2015
Merge pull request #1 from woothemes/master
4d32da5 
repo sync
@rrshroff rrshroff mentioned this issue Jun 19, 2024
Closed
5 tasks
@Nubianqween4 Nubianqween4 mentioned this issue Jun 20, 2024
Closed
5 tasks
@panostzemis panostzemis mentioned this issue Jun 27, 2024
Closed
5 tasks
@mikejolley mikejolley mentioned this issue Jul 12, 2024
Merged
12 tasks
@Feri-6 Feri-6 mentioned this issue Jul 12, 2024
Open
5 tasks
@samueljseay samueljseay mentioned this issue Jul 19, 2024
Merged
12 tasks
@coreymckrill coreymckrill mentioned this issue Aug 13, 2024
Closed
5 tasks
@mreishus mreishus mentioned this issue Aug 19, 2024
Open
@lanej0 lanej0 mentioned this issue Sep 6, 2024
Open
5 tasks
@chihsuan chihsuan mentioned this issue Sep 13, 2024
Closed
@ChrisPlaneta ChrisPlaneta mentioned this issue Sep 13, 2024
Closed
5 tasks
@lanej0 lanej0 mentioned this issue Sep 17, 2024
Closed
5 tasks
@BackuPs BackuPs mentioned this issue Sep 19, 2024
Open
5 tasks
@tomoveout tomoveout mentioned this issue Sep 20, 2024
Open
5 tasks
@lanej0 lanej0 mentioned this issue Oct 1, 2024
Closed
@tomoveout tomoveout mentioned this issue Oct 15, 2024
Closed
@Aljullu Aljullu mentioned this issue Oct 16, 2024
Closed
@gglobalstep gglobalstep mentioned this issue Oct 17, 2024
Closed
5 tasks
bor0 added a commit that referenced this issue Oct 27, 2024
@bor0
Add a is_string check to the params iterator
ed39316 
This works fine:

```
curl -u bor0:asdf -X OPTIONS "localhost:8080/wp-json/wc/store/v1/products?_unstable_tax_asdf_operator=1" | jq
```

However, this causes a fatal error `PHP Fatal error:  Uncaught TypeError: str_starts_with(): Argument #1 ($haystack) must be of type string, int given`:

```
curl -u bor0:asdf -X OPTIONS "localhost:8080/wp-json/wc/store/v1/products?1=2" | jq
```
bor0 added a commit that referenced this issue Oct 27, 2024
@bor0
Add a is_string check to the params iterator
451857d 
This works fine:

```
curl -u bor0:asdf -X OPTIONS "localhost:8080/wp-json/wc/store/v1/products?_unstable_tax_asdf_operator=1" | jq
```

However, this causes a fatal error `PHP Fatal error:  Uncaught TypeError: str_starts_with(): Argument #1 ($haystack) must be of type string, int given`:

```
curl -u bor0:asdf -X OPTIONS "localhost:8080/wp-json/wc/store/v1/products?1=2" | jq
```
bor0 added a commit that referenced this issue Oct 28, 2024
@bor0
Add a is_string check to the params iterator (#52361)
1f0dc7a 
This works fine:

```
curl -u bor0:asdf -X OPTIONS "localhost:8080/wp-json/wc/store/v1/products?_unstable_tax_asdf_operator=1" | jq
```

However, this causes a fatal error `PHP Fatal error:  Uncaught TypeError: str_starts_with(): Argument #1 ($haystack) must be of type string, int given`:

```
curl -u bor0:asdf -X OPTIONS "localhost:8080/wp-json/wc/store/v1/products?1=2" | jq
```
@githuzz githuzz mentioned this issue Nov 7, 2024
Closed
@Wiseshirt123 Wiseshirt123 mentioned this issue Nov 8, 2024
Closed
5 tasks
github-actions bot pushed a commit that referenced this issue Nov 12, 2024
@bor0
Add a is_string check to the params iterator (#52361)
029ef91 
This works fine:

```
curl -u bor0:asdf -X OPTIONS "localhost:8080/wp-json/wc/store/v1/products?_unstable_tax_asdf_operator=1" | jq
```

However, this causes a fatal error `PHP Fatal error:  Uncaught TypeError: str_starts_with(): Argument #1 ($haystack) must be of type string, int given`:

```
curl -u bor0:asdf -X OPTIONS "localhost:8080/wp-json/wc/store/v1/products?1=2" | jq
```
naman03malhotra pushed a commit that referenced this issue Nov 12, 2024
@github-actions @bor0
Cherry pick 52361 into release/9.4 (#52740)
0bd6a01 
* Add a `is_string` check to the params iterator (#52361)

This works fine:

```
curl -u bor0:asdf -X OPTIONS "localhost:8080/wp-json/wc/store/v1/products?_unstable_tax_asdf_operator=1" | jq
```

However, this causes a fatal error `PHP Fatal error:  Uncaught TypeError: str_starts_with(): Argument #1 ($haystack) must be of type string, int given`:

```
curl -u bor0:asdf -X OPTIONS "localhost:8080/wp-json/wc/store/v1/products?1=2" | jq
```

* Prep for cherry pick 52361

---------

Co-authored-by: Boro Sitnikovski <[email protected]>
Co-authored-by: WooCommerce Bot <[email protected]>
@kaushikasomaiya kaushikasomaiya mentioned this issue Nov 14, 2024
Open
5 tasks
@Nico13100 Nico13100 mentioned this issue Nov 19, 2024
Closed
5 tasks
@mikejolley mikejolley mentioned this issue Nov 21, 2024
Closed
5 tasks
@paaljoachim paaljoachim mentioned this issue Dec 13, 2024
Closed
@mordeth mordeth mentioned this issue Dec 13, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jameskoster jameskoster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jameskoster @NiklasHogefjord