Upgrade to support Xcode 14.0 #7062

mokagio · 2022-06-09T10:03:50Z

Note: While I am listed as the PR author, @crazytonyli did all the heavy lifting to get the app building and up-to-date through all the betas! —@mokagio

Description

This is going to be a long running branch to (try to) stay on top of the Xcode 14 betas PRs.

I expected many of you will want to checkout this branch locally to play with it. As such, I think we should keep it alive by merging trunk into it. But, I think once we'll officially switch to Xcode 14 stable, it'll make sense to do a big rebase so the history stays tidy.

I called the branch xcode-14. This might give us the option to keep the beta branch stable (🙃 🙂) and work on a new beta support without breaking the "stable" branch. That is, we might have an xcode-14-beta-2 branch in the future.

Ideally, we should implement as many fixes for errors and warnings found here as possible on trunk. See:

Update Charts from 3.6.0 to 4.0.3 and migrate to SPM #7057

Testing instructions

Download Xcode 14 beta 1 and run this branch 😅 .

If you do, you might notice a bunch of:

Cannot access property 'cancellableSiteID' with a non-sendable type 'AnyCancellable?' from non-isolated deinit; this is an error in Swift 6

I haven't looked into it yet, other than finding this thread about it in the Swift forums.

Screenshots

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

This also touched all the schemes to update the `LastUpgradeVersion` to track they were checked in Xcode 14.0.

wpmobilebot · 2022-06-09T10:17:35Z

You can test the changes from this Pull Request by:

Clicking here or scanning the QR code below to access App Center
Then installing the build number pr7062-21de10c on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Fix #7393

On iOS 16, `DateFormatter` returns a different localized string for template format 'MMM d, h:mm a', compared to previous iOS versions. Feeback to Apple: FB11335645.

Make the app compatible with Xcode 14

crazytonyli · 2022-09-15T00:50:14Z

Hi @mokagio , do you think this PR is ready for review now?

mokagio · 2022-09-15T03:56:07Z

Hi @mokagio , do you think this PR is ready for review now?

Yes it is! Pushing the button and reaching out to the devs.

peril-woocommerce · 2022-09-15T03:56:43Z

	Warnings
⚠️	PR is not assigned to a milestone.

Generated by 🚫 dangerJS

itsmeichigo

This works great for me both on the simulator and physical devices.
Thanks for the updates!

This seems to address the "Update project to recommended settings" warning for the Pods project.

…ings Upgrade project to Xcode 14.0 stable recommended settings

jaclync

Working as before on an iOS 15 device and iOS 16 simulator! Just some minor non-blocking questions

jaclync · 2022-09-15T06:18:13Z

WooCommerce/Classes/ViewRelated/Hub Menu/HubMenuViewController.swift

+        super.viewWillDisappear(animated)
+
+        if #available(iOS 16.0, *) {
+            self.navigationController?.setNavigationBarHidden(false, animated: animated)
+        }


nit: does it make sense to reverse the order of the super call since this is a "disappear" event?

Suggested change

super.viewWillDisappear(animated)

if #available(iOS 16.0, *) {

self.navigationController?.setNavigationBarHidden(false, animated: animated)

}

if #available(iOS 16.0, *) {

self.navigationController?.setNavigationBarHidden(false, animated: animated)

}

super.viewWillDisappear(animated)

The API doc says

If you override this method, you must call super at some point in your implementation.

I don't think the order of these two statements would make any difference, the pop animation should begin and end at the same time.

jaclync · 2022-09-15T06:22:40Z

WooCommerce/Classes/ViewRelated/Hub Menu/HubMenuViewController.swift

+        // We want to hide navigation bar *only* on HubMenu screen. But on iOS 16, the `navigationBarHidden(true)`
+        // modifier on `HubMenu` view hides the navigation bar for the whole navigation stack.
+        // Here we manually hide or show navigation bar when entering or leaving the HubMenu screen.
+        if #available(iOS 16.0, *) {


do you still see the navigation bar issue #7091 with the latest Xcode 14? somehow I don't see this issue anymore on trunk using Xcode 14 in an iOS 16.0 simulator. I don't have an iOS 16 device though, might be worth testing on one to confirm if this workaround is still needed.

Just tried to comment out viewWillAppear and viewWillDisappear - reproduced the issue on the device:

Payments Reviews

@jaclync Hmm, that's strange. I just run the trunk branch on an iPhone 14 simulator using Xcode 14, and verified this is still an issue.

Sounds like something odd on my end then, thanks for checking both!

jaclync · 2022-09-15T06:24:16Z

WooCommerce/Classes/ViewRelated/Orders/Order Creation/PaymentSection/ShippingLineDetails.swift

@@ -52,6 +52,9 @@ struct ShippingLineDetails: View {
                                                 symbol: nil,
                                                 keyboardType: .default)
                                .accessibilityIdentifier("add-shipping-name-field")
+                                .onTapGesture {
+                                    focusAmountInput = false


do you have the testing steps for this change?

This code was added so that the test_creat_new_order UI test can pass on CI. It's a strange issue though, since the test failure only occurs on CI, not on my mac.

BTW, the issue was mentioned in my original PR.

Here is a very strange issue only happens in UI test on CI. I had to explicitly make a text field loose keyboard focus by changing the binding variable, for the other "add-shipping-name-field" text field to gain keyboard focus.

BTW, you can find my many attempts of fixing this issue in this buildkite branch builds.

From the test result bundle (you can download one from the artifacts of this step), it appears even thought "add-shipping-name-field" is tapped, it's still "add-shipping-amount-field" that has the keyboard focus, which caused the test to fail.

jaclync · 2022-09-15T06:24:56Z

...ommerce/WooCommerceTests/ViewRelated/Dashboard/Stats V4/StoreStatsPeriodViewModelTests.swift

+        if #available(iOS 16.0, *) {
+            XCTAssertEqual(timeRangeBarViewModels.map { $0.timeRangeText }, ["Monday, Jan 3", "Monday, Jan 3 at 1:00 AM"])
+        } else {
+            XCTAssertEqual(timeRangeBarViewModels.map { $0.timeRangeText }, ["Monday, Jan 3", "Monday, Jan 3, 1:00 AM"])
+        }


nice catch!

ealeksandrov

✅ Xcode 13.4.1 + iOS 14.5, 15.5 simulators
✅ Xcode 14 + iOS 16 simulator + iOS 16 device

There are couple of new warnings in Xcode 14:

warning build: Run script build phase 'SwiftLint' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase.


warning build: Run script build phase 'Check for nested frameworks' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase.

crazytonyli · 2022-09-15T21:36:04Z

Hi @jaclync , I'll merge this PR for now. I'm happy to follow up if you have any further comments. Thanks! 😄

Upgrade WooFoundation to recommended Xcode 14.0 beta 1 settings

5f86640

This also touched all the schemes to update the `LastUpgradeVersion` to track they were checked in Xcode 14.0.

mokagio added status: do not merge Dependent on another PR, ready for review but not ready for merge. category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. labels Jun 9, 2022

crazytonyli added 12 commits July 28, 2022 15:53

Merge branch 'trunk' into xcode-14

f22b616

Merge branch 'trunk' into xcode-14

5688454

Merge branch 'trunk' into xcode-14

73e0ff8

Merge branch 'trunk' into xcode-14

d5c1cdd

Merge branch 'trunk' into xcode-14

9f3a741

Fix a code signing issue on Xcode 14 beta 4

4318ef1

On iOS 16, use UIKit to hide or show navigation bar on the HubMenu

750f5f8

Fix #7393

Assert the correct localized date string based on OS version

ea87d95

On iOS 16, `DateFormatter` returns a different localized string for template format 'MMM d, h:mm a', compared to previous iOS versions. Feeback to Apple: FB11335645.

Explicitly make amount text field lose keyboard focus

af1e24b

Use Xcode 14 on CI

2a36b11

Use iPhone 14 to run UI tests

0405e14

Merge pull request #7371 from woocommerce/xcode-14-workarounds

92915ef

Make the app compatible with Xcode 14

mokagio marked this pull request as ready for review September 15, 2022 03:56

mokagio changed the title ~~WIP – Xcode 14.0~~ Upgrade to support Xcode 14.0 Sep 15, 2022

itsmeichigo approved these changes Sep 15, 2022

View reviewed changes

mokagio and others added 3 commits September 15, 2022 15:16

Upgrade project to Xcode 14.0 stable recommended settings

63e6e05

Upgrade CocoaPods to version 1.11.3

eebb6e8

This seems to address the "Update project to recommended settings" warning for the Pods project.

Merge pull request #7725 from woocommerce/mokagio/update-project-sett…

21de10c

…ings Upgrade project to Xcode 14.0 stable recommended settings

jaclync approved these changes Sep 15, 2022

View reviewed changes

ealeksandrov approved these changes Sep 15, 2022

View reviewed changes

mokagio mentioned this pull request Sep 15, 2022

Update Tracks to 0.13.0-beta.2 to address verbose Sentry logs #7728

Merged

1 task

crazytonyli merged commit c457ff0 into trunk Sep 15, 2022

crazytonyli deleted the xcode-14 branch September 15, 2022 21:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to support Xcode 14.0 #7062

Upgrade to support Xcode 14.0 #7062

mokagio commented Jun 9, 2022 •

edited

Loading

wpmobilebot commented Jun 9, 2022 •

edited

Loading

crazytonyli commented Sep 15, 2022

mokagio commented Sep 15, 2022

peril-woocommerce bot commented Sep 15, 2022

itsmeichigo left a comment

jaclync left a comment

jaclync Sep 15, 2022

crazytonyli Sep 15, 2022

jaclync Sep 15, 2022

ealeksandrov Sep 15, 2022

crazytonyli Sep 15, 2022 •

edited

Loading

jaclync Sep 16, 2022

jaclync Sep 15, 2022

crazytonyli Sep 15, 2022

crazytonyli Sep 15, 2022

jaclync Sep 15, 2022

ealeksandrov left a comment

crazytonyli commented Sep 15, 2022

Upgrade to support Xcode 14.0 #7062

Upgrade to support Xcode 14.0 #7062

Conversation

mokagio commented Jun 9, 2022 • edited Loading

Description

Testing instructions

Screenshots

wpmobilebot commented Jun 9, 2022 • edited Loading

crazytonyli commented Sep 15, 2022

mokagio commented Sep 15, 2022

peril-woocommerce bot commented Sep 15, 2022

itsmeichigo left a comment

Choose a reason for hiding this comment

jaclync left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

crazytonyli Sep 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ealeksandrov left a comment

Choose a reason for hiding this comment

crazytonyli commented Sep 15, 2022

mokagio commented Jun 9, 2022 •

edited

Loading

wpmobilebot commented Jun 9, 2022 •

edited

Loading

crazytonyli Sep 15, 2022 •

edited

Loading