Update Charts from 3.6.0 to 4.0.3 and migrate to SPM #7057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next, we'll move it to Swift Package Manager, to make progress on running the app on Xcode 14.0. The upgrade also required to: - Rename `IAxisValueFormatter` to `AxisValueFormatter` - Update a `Description` access now that it's no longer `Optional` - Update a `.fill` assignment to match new types modeling See ChartsOrg/Charts@v3.6.0...v4.0.3
This is the only way we found to make the app build under Xcode 14.0 beta 1.
mokagio
commented
Jun 9, 2022
| @@ -1,6 +1,6 @@ | |||
| import Foundation | |||
| import Charts | |||
|
|
|||
| import UIKit | |||
There was a problem hiding this comment.
This was required for the file to compile.
I guess Charts the Package doesn't (or can't?) implicitly import UIKit like Charts the Pod did.
mokagio
commented
Jun 9, 2022
| @@ -374,7 +374,7 @@ private extension StoreStatsV4PeriodViewController { | |||
|
|
|||
| func configureChart() { | |||
| lineChartView.marker = StoreStatsChartCircleMarker() | |||
| lineChartView.chartDescription?.enabled = false | |||
| lineChartView.chartDescription.enabled = false | |||
There was a problem hiding this comment.
A way to double check these changes is to open the diff between versions 3.6.0 and 4.0.3 and do a string search for the changes.
There was a problem hiding this comment.
Nice way for checking the changes between 2 versions 👍
You can test the changes from this Pull Request by:
|
mokagio
added
the
category: tooling
jaclync
approved these changes
Jun 9, 2022
| @@ -374,7 +374,7 @@ private extension StoreStatsV4PeriodViewController { | |||
|
|
|||
| func configureChart() { | |||
| lineChartView.marker = StoreStatsChartCircleMarker() | |||
| lineChartView.chartDescription?.enabled = false | |||
| lineChartView.chartDescription.enabled = false | |||
There was a problem hiding this comment.
Nice way for checking the changes between 2 versions 👍
This was referenced Jun 9, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For a reason unknown to me, Xcode 14.0 beta 1 can't compile Charts when installed via CocoaPods. That's not a big deal for us, since we plan to slowly move away from CocoaPods in favor of Swift Package Manager.
This PR does exactly that for Charts, feeding two birds with one spoon.
Testing instructions
A green CI should be enough to ensure the migration process was successful, but there could be unexpected regression as a result of bugs in the library.
I'm waiting for the installable build to verify that, butI'd appreciate other eyes on that, too.Screenshots
I don't have a store linked to my account with lots of activity. This is the only graph I could use to verify the upgrade:
RELEASE-NOTES.txtif necessary.