Sentry: Disable tracking HTTP client errors and app hangs #10373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmeichigo
added
type: enhancement
You can test the changes from this Pull Request by:
|
Podfile
Outdated
| # pod 'Automattic-Tracks-iOS', :git => 'https://github.com/Automattic/Automattic-Tracks-iOS.git', :branch => 'trunk' | ||
| # pod 'Automattic-Tracks-iOS', :git => 'https://github.com/Automattic/Automattic-Tracks-iOS.git', :commit => '' | ||
| pod 'Automattic-Tracks-iOS', :git => 'https://github.com/Automattic/Automattic-Tracks-iOS.git', :commit => '1d3bb8030b3aed54c2b24c18fb95f3945ac63f9f' |
There was a problem hiding this comment.
Looks like there have been a few updates here. Should we point it to the latest commit, d841ba6b6a048218a8d8507b8d71c0c1349036ae?
There was a problem hiding this comment.
Since the PR has been merged, I've point the library to trunk now. I'll update it to a version number once the update is released.
There was a problem hiding this comment.
Since I cannot trigger CI to build the updated version of the library on Cocoapods, I'll merge this PR for now to make it to the code freeze (pointing the library to trunk). Hopefully, a release manager would help with updating the library version cc @spencertransier 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #10372
Please also review Automattic/Automattic-Tracks-iOS#261.
Description
This PR updates
Automattic-Tracks-iOSand adds configs to disable HTTP client error and app hang tracking on Sentry. The purpose is to stop reports of these errors bloating up Sentry report list - we'll find better ways to keep track of the issues.Testing instructions
It's not straightforward to check that these errors are not tracked from debug builds. You can use breakpoints to ensure that the options are delivered to
Automattic-Tracks-iOS'sCrashLoggingfile successfully.Screenshots
N/A
RELEASE-NOTES.txtif necessary.