Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to config Sentry app hang and HTTP client error tracking #261

Merged
merged 6 commits into from
Aug 2, 2023

Conversation

itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Aug 2, 2023

Part of woocommerce/woocommerce-ios#10372

Description

Since Sentry v8.0.0, app hang and HTTP client errors are tracked by default. These reports overflow the issue list for WCiOS, so we want to add an option to disable these tracking from our side.

This PR adds new options for CrashLoggingDataProvider: enableAppHangTracking and enableCaptureFailedRequests. These are used to configure relevant Sentry options. They are kept as true false by default not to affect any existing apps using this dependency and other apps can opt in if needed.


  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@itsmeichigo
Copy link
Contributor Author

@mokagio I'm setting the new version with 2.3.0 as we are not planning to ship a new version soon for this library. I'm still confused about the versioning since the last update of WordPressUI, so pinging you to make sure that this is ok.

@itsmeichigo itsmeichigo merged commit aad902b into trunk Aug 2, 2023
@itsmeichigo itsmeichigo deleted the feat/option-to-config-sentry branch August 2, 2023 10:59
@itsmeichigo
Copy link
Contributor Author

itsmeichigo commented Aug 3, 2023

@mokagio I merged the change, could you help with the release, please? 🙇
Edited: I created a release for 2.3.0 myself but couldn't trigger CI to push a new version of the library on Cocoapods. I'll proceed to merge the WCiOS PR pointing to trunk of this library for now.

@mokagio
Copy link
Contributor

mokagio commented Aug 7, 2023

@itsmeichigo 👍 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants