This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Checkout Terms Block: Fix Terms and Conditions checkbox position in editor (#5150) #5191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunyatasattva
added
skip-changelog
rubikuserbot
requested review from
a team and
tjcafferkey
and removed request for
a team
|
Size Change: +11 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
mikejolley
approved these changes
Nov 19, 2021
sunyatasattva
force-pushed
the
fix/5150-tos-checkbox-not-aligned
branch
from
863f38b to
d8a42cd
Compare
…ditor (#5150) Within the editor, the checkbox appeared aligned at the bottom of the paragraph, while on the front-end it would appear aligned at the top. The alignment was actually correct but a top margin was assigned to checkboxes in the backend. Instead of removing that globally, this commit resets it for checkboxes within the checkout block.
sunyatasattva
force-pushed
the
fix/5150-tos-checkbox-not-aligned
branch
from
d8a42cd to
6dc9cf5
Compare
Aljullu
added
type: bug
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
…ditor (woocommerce#5150) (woocommerce#5191) Within the editor, the checkbox appeared aligned at the bottom of the paragraph, while on the front-end it would appear aligned at the top. The alignment was actually correct but a top margin was assigned to checkboxes in the backend. Instead of removing that globally, this commit resets it for checkboxes within the checkout block.
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
…ditor (woocommerce#5150) (woocommerce#5191) Within the editor, the checkbox appeared aligned at the bottom of the paragraph, while on the front-end it would appear aligned at the top. The alignment was actually correct but a top margin was assigned to checkboxes in the backend. Instead of removing that globally, this commit resets it for checkboxes within the checkout block.
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the editor, the checkbox appeared aligned at the bottom of the paragraph, while on the front-end it would appear aligned at the top. The alignment was actually correct but a top margin was assigned to checkboxes in the backend.
Instead of removing that globally, this commit resets it for checkboxes within the checkout block.
Fixes #5150
Screenshots
Editor (before):
Editor (after):
Reference (front-end):
Testing
Manual Testing
How to test the changes in this Pull Request:
Require checkboxdisplay optionUser Facing Testing
Same as above
Changelog