This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Keep top margin for create account section in editor #5633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslange
added
status: needs review
block: checkout
rubikuserbot
requested review from
a team and
opr
and removed request for
a team
|
Hello @sunyatasattva 👋 Given that you worked on #5191, I manually added you as a reviewer. If you don't have the capacity to do the review, feel free to unassign you. 😀 |
|
Size Change: +43 B (0%) Total Size: 745 kB
ℹ️ View Unchanged
|
sunyatasattva
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
This LGTM @nielslange thanks for spotting that. We did some regression testing and we didn't see that one.
I wonder if, long term, the best solution is adding exceptions to the margin rule instead of maybe taking a more generic approach. For now, I think this is totally fine! 👍
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
nielslange
commented
Jan 26, 2022
assets/js/blocks/cart-checkout/checkout/inner-blocks/checkout-terms-block/editor.scss
Outdated
Show resolved
Hide resolved
That's true. How would you suggest proceeding in this case, though, to solve the regression bug? |
|
What about adding bottom margin to the text input containers? Can we try that and see if that doesn't create any disaster? Because of how margin collapsing works, that shouldn't be a disaster. If that makes it a disaster (perhaps because they are floating), then we can just divide the current input margin by two between top and bottom. What do you think? |
nielslange
force-pushed
the
fix/adjust-create-account-section-margin
branch
from
af7b9ec to
a05ef61
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5191, we've adjusted the T&C checkbox position. This change lead to the fact that the top margin of the create account section disappeared. This PR aims to correct this regression.
Screenshots
Testing
Account Options » Allow shoppers to sign up for a user account during checkout.Create an account?section has sufficient top margin.User Facing Testing
Changelog