This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Ensure consistent spacing for checkout input fields #5699
Labels
block: checkout
Issues related to the checkout block.
focus: global styles
Issues that involve styles/css/layout structure.
type: bug
The issue/PR concerns a confirmed bug.
type: good first issue
The issue is a good candidate for the first community contribution/for a newcomer to the team.
Describe the bug
In #5633, we adjusted the spacing of the
Create an account?
checkbox below the email address input field. While testing the release, I noticed that this fix caused a regression bug. When displaying theCreate an account?
checkbox, the email address input field gets pushed down. This problem is caused by:https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/360827baff0b00d6852882225ecfc8d5b071c75a/assets/js/base/components/text-input/style.scss#L113-L115
Once the
Create an account?
checkbox is visible, the email address input field is no longer the only child and instead ofmargin-top: 0
this element is usingmargin-top: 1.5em
.To reproduce
WP Admin » WooCommerce » Settings » Account & Privacy
.Allow customers to create an account during checkout
in the sectionAccount creation
.Allow shoppers to sign up for a user account during checkout
in the sectionAccount options
in the sidebar.Create an account?
checkbox becomes visible.Screen recording
Expected behavior
When adding the
Create an account?
checkbox, the spacing of the email address input field should remain untouched.The text was updated successfully, but these errors were encountered: