Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Terms and Conditions block: checkbox not correctly aligned in the editor #5150

Closed
Aljullu opened this issue Nov 16, 2021 · 0 comments · Fixed by #5191
Closed

Terms and Conditions block: checkbox not correctly aligned in the editor #5150

Aljullu opened this issue Nov 16, 2021 · 0 comments · Fixed by #5191
Assignees
@sunyatasattva
Labels
block: checkout Issues related to the checkout block. focus: global styles Issues that involve styles/css/layout structure. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Nov 16, 2021

To reproduce

  1. Create a new page and add the Checkout block.
  2. Click on the Terms and Conditions inner block and enable the Require checkbox attribute.
  3. Notice the checkbox is not vertically aligned correctly in the editor (this issue doesn't affect the frontend).

Expected behavior

In the editor, the checkbox should be aligned with the first line, like in the frontend.

Screenshots

Editor:
imatge

Frontend:
imatge
@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. block: checkout Issues related to the checkout block. focus: global styles Issues that involve styles/css/layout structure. labels Nov 16, 2021
@sunyatasattva sunyatasattva self-assigned this Nov 17, 2021
sunyatasattva added a commit that referenced this issue Nov 18, 2021
@sunyatasattva
Checkout Terms Block: Fix Terms and Conditions checkbox position in e…
863f38b 
…ditor (#5150)

Within the editor, the checkbox appeared aligned at the bottom of the paragraph, while
on the front-end it would appear aligned at the top. The alignment was actually correct
but a top margin was assigned to checkboxes in the backend.

Instead of removing that globally, this commit resets it for checkboxes within the checkout
block.
@sunyatasattva sunyatasattva mentioned this issue Nov 18, 2021
Merged
sunyatasattva added a commit that referenced this issue Nov 22, 2021
@sunyatasattva
Checkout Terms Block: Fix Terms and Conditions checkbox position in e…
d8a42cd 
…ditor (#5150)

Within the editor, the checkbox appeared aligned at the bottom of the paragraph, while
on the front-end it would appear aligned at the top. The alignment was actually correct
but a top margin was assigned to checkboxes in the backend.

Instead of removing that globally, this commit resets it for checkboxes within the checkout
block.
sunyatasattva added a commit that referenced this issue Nov 22, 2021
@sunyatasattva
Checkout Terms Block: Fix Terms and Conditions checkbox position in e…
6dc9cf5 
…ditor (#5150)

Within the editor, the checkbox appeared aligned at the bottom of the paragraph, while
on the front-end it would appear aligned at the top. The alignment was actually correct
but a top margin was assigned to checkboxes in the backend.

Instead of removing that globally, this commit resets it for checkboxes within the checkout
block.
sunyatasattva added a commit that referenced this issue Nov 22, 2021
@sunyatasattva
Checkout Terms Block: Fix Terms and Conditions checkbox position in e…
710e45d 
…ditor (#5150) (#5191)

Within the editor, the checkbox appeared aligned at the bottom of the paragraph, while
on the front-end it would appear aligned at the top. The alignment was actually correct
but a top margin was assigned to checkboxes in the backend.

Instead of removing that globally, this commit resets it for checkboxes within the checkout
block.
jonny-bull pushed a commit to jonny-bull/woocommerce-gutenberg-products-block that referenced this issue Dec 14, 2021
@sunyatasattva @jonny-bull
Checkout Terms Block: Fix Terms and Conditions checkbox position in e…
5e16467 
…ditor (woocommerce#5150) (woocommerce#5191)

Within the editor, the checkbox appeared aligned at the bottom of the paragraph, while
on the front-end it would appear aligned at the top. The alignment was actually correct
but a top margin was assigned to checkboxes in the backend.

Instead of removing that globally, this commit resets it for checkboxes within the checkout
block.
jonny-bull pushed a commit to jonny-bull/woocommerce-gutenberg-products-block that referenced this issue Dec 16, 2021
@sunyatasattva @jonny-bull
Checkout Terms Block: Fix Terms and Conditions checkbox position in e…
27fcaaa 
…ditor (woocommerce#5150) (woocommerce#5191)

Within the editor, the checkbox appeared aligned at the bottom of the paragraph, while
on the front-end it would appear aligned at the top. The alignment was actually correct
but a top margin was assigned to checkboxes in the backend.

Instead of removing that globally, this commit resets it for checkboxes within the checkout
block.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sunyatasattva sunyatasattva

Labels
block: checkout Issues related to the checkout block. focus: global styles Issues that involve styles/css/layout structure. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Milestone
No milestone
2 participants
@sunyatasattva @Aljullu