This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix notice banner links for Legacy notices #9996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
wavvves
and removed request for
a team
tarunvijwani
added
status: needs review
type: bug
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +21 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
wavvves
approved these changes
Jun 28, 2023
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Make a PR to @wordpress/e2e-test-utils-playwright to add ...Make a PR to @wordpress/e2e-test-utils-playwright to add this method. Inserts a block after a given client ID.
woocommerce-blocks/tests/e2e-pw/utils/editor/EditorUtils.ts Lines 23 to 37 in bb9c58d 🚀 This comment was generated by the automations bot based on a
|
This is a workaround to wait for the save button to be en...This is a workaround to wait for the save button to be enabled. It works only without Gutenberg enabled. We have to refactor this. 🚀 This comment was generated by the automations bot based on a
|
tarunvijwani
force-pushed
the
fix/9134-notice-banner-links
branch
from
bb9c58d to
429f47a
Compare
|
@tarunvijwani Noting that using the & below does not close both tickets. Best thing is to add individual lines. I think commas might work on the same line |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few third-party plugins were still using the
wc-forwardclass instead ofwp-element-buttonthat was causing the links in the notice banner to appear on the left and link buttons. With this PR, we're making the banner links compatible for Legacy notices by just focusing onwc-forwardclass.Fixes #9609 & #9134
Also added the underline to the links present in notice banner as per the figma design: hqyJB5F38BOXTrOyxehUZH-fi-2141%3A6588
Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog