Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

The styling of CTA buttons in notices is not displaying correctly on legacy themes #9609

Closed
xristos3490 opened this issue May 26, 2023 · 1 comment · Fixed by #9996
Closed
Assignees
Labels
type: bug The issue/PR concerns a confirmed bug.

Comments

@xristos3490
Copy link
Member

Describe the bug

After a recent update to the WC core that prevents legacy themes from displaying blocks-based CSS classes, like wp-element-button, to reduce the risk/footprint for existing stores.

The new C&C-inspired notices are only applied to stores that have the Cart and Checkout blocks installed, without checking for an active block theme. This causes a problem with the CTA buttons, which do not appear visually appealing when a merchant has C&C blocks installed in a legacy theme.

I’m thinking of three possible solutions here:

  • Re-evaluate core change
  • Only apply the new notices for block themes that use C&C blocks
  • Adjust the CSS rule that controls the styling of the CTA buttons for the notices to not depend on the wp-element-button class.

To reproduce

Steps to reproduce the behavior:

  1. Go to a store using a legacy theme (e.g., Storefront) and ensure you use at least WC 7.8-beta1
  2. Enable C&C blocks in the checkout process
  3. Go to any single product page and add it to the cart.
  4. Check the CTA button in the success notice and see that it's not working as expected.

Expected behavior

The button should be appearing on the right side of the notice.

Screenshots

Screenshot 2023-05-26 at 4 03 32 PM
@xristos3490 xristos3490 added the type: bug The issue/PR concerns a confirmed bug. label May 26, 2023
@ralucaStan
Copy link
Contributor

@pmcpinto I've added this to the list of issues for Cycle 4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants