This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Render the single product title as an h1 when transforming from classic template #9748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
June 7, 2023 11:35
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: +6 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
kmanijak
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aljullu
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tarunvijwani
pushed a commit
that referenced
this pull request
Jun 7, 2023
tarhi-saad
added
type: bug
The issue/PR concerns a confirmed bug.
focus: template
Related to API powering block template functionality in the Site Editor
type: enhancement
The issue is a request for an enhancement.
and removed
type: bug
The issue/PR concerns a confirmed bug.
focus: template
Related to API powering block template functionality in the Site Editor
labels
Jun 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
type: bug
The issue/PR concerns a confirmed bug.
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When transforming from the classic template, the title block will be rendered as
h1
.It was missing from this PR #9698
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Changelog