This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Blockified Single Product Template: use h1 for the Product Title #9698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
type: enhancement
woocommercebot
requested review from
a team and
Aljullu
and removed request for
a team
|
cc @shaunandrews since it is a style change (even if minimum). |
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
Aljullu
approved these changes
Jun 2, 2023
| @@ -69,4 +69,4 @@ <h2 class="wp-block-heading">Related products</h2> | |||
| </div> | |||
| <!-- /wp:group --> | |||
|
|
|||
| <!-- wp:template-part {"slug":"footer"} /--> | |||
| <!-- wp:template-part {"slug":"footer"} /--> | |||
There was a problem hiding this comment.
Not sure if it's really important, but there used to be a white line at the end of this line.
gigitux
deleted the
9695-blockified-single-product-template-modify-the-default-header-level-for-the-product-title-from-h2-to-h1
branch
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xristos3490 noticed that we are using
h2for the Product Title. This PR fixes it.Fixes #9695
Screenshots
Testing
User Facing Testing
h1is set.WooCommerce Visibility
Performance Impact
Changelog