This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Only show the Mini Cart count badge when there are items in the cart #9259
Merged
Aljullu
merged 6 commits into
trunk
from
fix/9185-mini-cart-badge-count-only-when-filled
May 11, 2023
Merged
Only show the Mini Cart count badge when there are items in the cart #9259
Aljullu
merged 6 commits into
trunk
from
fix/9185-mini-cart-badge-count-only-when-filled
May 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
type: enhancement
The issue is a request for an enhancement.
needs: design
The issue requires design input/work from a designer.
block: mini-cart
Issues related to the Mini-Cart block.
labels
Apr 27, 2023
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: -770 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
Stale issues and PRs have had no updates for 60 days.
label
May 5, 2023
Aljullu
force-pushed
the
fix/9185-mini-cart-badge-count-only-when-filled
branch
from
May 9, 2023 07:17
95ff6ce
to
132871b
Compare
Aljullu
force-pushed
the
fix/9185-mini-cart-badge-count-only-when-filled
branch
from
May 9, 2023 07:20
132871b
to
a6b6303
Compare
Aljullu
changed the title
[WIP] Only show the Mini Cart count badge when there are items in the cart
Only show the Mini Cart count badge when there are items in the cart
May 9, 2023
Aljullu
added
status: needs review
and removed
status: stale
Stale issues and PRs have had no updates for 60 days.
labels
May 9, 2023
woocommercebot
requested review from
a team and
nefeline
and removed request for
a team
May 9, 2023 07:27
nefeline
approved these changes
May 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
✅ Confirmed the mini cart count badge is now displayed only when there are items in the cart.
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
May 11, 2023
mikejolley
removed
the
needs: design
The issue requires design input/work from a designer.
label
May 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: mini-cart
Issues related to the Mini-Cart block.
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so the Mini Cart count badge is only rendered when there is at least one item in the cart. It also updates the badge styles to the new designs.
Fixes #9185.
Testing
User Facing Testing
Enregistrament.de.pantalla.des.de.2023-05-09.09-25-59.webm
WooCommerce Visibility
Changelog