Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Mini-Cart Block: Hide badge count when empty #9185

Closed
Tracked by #9198
shaunandrews opened this issue Apr 24, 2023 · 5 comments · Fixed by #9259
Closed
Tracked by #9198

Mini-Cart Block: Hide badge count when empty #9185

shaunandrews opened this issue Apr 24, 2023 · 5 comments · Fixed by #9259
Assignees
Labels
block: mini-cart Issues related to the Mini-Cart block. needs: design The issue requires design input/work from a designer. type: enhancement The issue is a request for an enhancement.

Comments

@shaunandrews
Copy link

CleanShot 2023-04-24 at 12 05 26@2x

When the cart is empty, the Mini-Cart block continues to show a badge with a count of '0'. It's pretty strange to see, and obscures the shape of the cart icon, making it hard to recognize.

Can we hide the badge when the cart is empty?

CleanShot 2023-04-24 at 12 07 50@2x

@shaunandrews shaunandrews added the type: enhancement The issue is a request for an enhancement. label Apr 24, 2023
@Aljullu Aljullu self-assigned this Apr 26, 2023
@Aljullu Aljullu added the block: mini-cart Issues related to the Mini-Cart block. label Apr 26, 2023
@Aljullu
Copy link
Contributor

Aljullu commented Apr 27, 2023

@shaunandrews I will need your help with the icons. These are the ones I'm working with:

icon-2
icon-1

Even though they are very similar, one is slightly smaller, causing a visual jump when switching from one to the other:

Enregistrament.de.pantalla.des.de.2023-04-27.12-52-08.webm

Do you think it would be possible to provide those two icons with the same sizing but one with the "badge space" removed?

@Aljullu Aljullu added the needs: design The issue requires design input/work from a designer. label Apr 27, 2023
@shaunandrews
Copy link
Author

I think it would be better to use one icon, and then make the badge an HTML element with a background and border. This element would then be positioned above the icon to create the overlapping effect.

@Aljullu
Copy link
Contributor

Aljullu commented May 8, 2023

@shaunandrews one question regarding that. My understanding is that the plan is to switch to the new badge style:

cleanshot-2023-04-27-at-15 21 59402x

Should we do the change in the Checkout block sidebar as well? Currently both badges share the same styling:

imatge

@shaunandrews
Copy link
Author

Its probably fine to match, though I imagine we'll want to change the checkout block sidebar — that badge count isn't very obvious in that context, and really breaks the visual balance.

@Aljullu
Copy link
Contributor

Aljullu commented May 9, 2023

Its probably fine to match, though I imagine we'll want to change the checkout block sidebar — that badge count isn't very obvious in that context, and really breaks the visual balance.

Ok, thanks! I will leave it as-is for now until the Checkout sidebar is worked on specifically. Regarding the Mini Cart badge, PR is ready: #9259. 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: mini-cart Issues related to the Mini-Cart block. needs: design The issue requires design input/work from a designer. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants