This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Checkout Block: Avoid using editor buttons in the post content to prevent inheriting global styles #8957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
status: needs review
block: checkout
woocommercebot
requested review from
a team and
wavvves
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/editor-components/no-payment-methods-notice/index.tsx
|
|
Size Change: -1.62 kB (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
|
There is a test fail because the tests don't factor in the inspector; if I cannot find a solution to include them, Ill remove the tests... |
mikejolley
force-pushed
the
fix/admin-button-styles-for-checkout
branch
from
638371d to
11fe7a5
Compare
|
Tests should be ok now. Ready for review. |
nielslange
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Thanks for working on this, @mikejolley. The changes work as expected and the updated unit test is passing. I noticed that a few e2e tests are failing, but they seem to be unrelated to this change and might be flaky tests.
nielslange
added
type: enhancement
mikejolley
force-pushed
the
fix/admin-button-styles-for-checkout
branch
from
d042812 to
243d448
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes a different approach to fixing #8571 and #8944 by removing editor-only buttons from the post content shown in the editor. Important notices and buttons are instead moved to the block inspector which mitigates those issues, as well as streamlining the appearance of the block in the editor so it more closely matches the frontend.
To summarise the changes:
This PR has therefore covered the following issues:
Fixes #8362
Fixes #8571
Fixes #8944
Screenshots
Express checkout
Before:
After:
Removed.
Payment methods
Before:
After:
Terms and conditions
Before:
After:
Testing
Automated Tests
JS tests will need to pass. I'll update if necessary as some elements were moved around.
User Facing Testing
Express payments
Payment methods
Terms and conditions
WooCommerce Visibility
Changelog