Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Some editor buttons of the Cart and Checkout blocks inherit the theme styling when they shouldn't #8571

Closed
Tracked by #8710
Aljullu opened this issue Feb 28, 2023 · 4 comments · Fixed by #8957
Closed
Tracked by #8710
Assignees
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. focus: accessibility The issue/PR is related to accessibility. type: bug The issue/PR concerns a confirmed bug.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Feb 28, 2023

To reproduce

  1. Make sure you don't have any payment method set up.
  2. Install TT3 and go to Appearance > Editor > edit one of the templates > Styles (white and black circle on the top right) > Browse Styles and select the Whisper style.
  3. Create a post or page and add the Cart and Checkout blocks.
  4. Notice some of the buttons inherit the theme styling (text color, borders, etc.), making them difficult to read:

Expected behavior

Buttons displayed in this kind of notices shouldn't inherit the theme styling.

@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. focus: accessibility The issue/PR is related to accessibility. block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. labels Feb 28, 2023
@ralucaStan
Copy link
Contributor

Thank you @Aljullu !

@nielslange
Copy link
Member

Internal discussion: p1679990642217489-slack-C8X6Q7XQU

@tarunvijwani
Copy link

tarunvijwani commented Apr 3, 2023

"Configure payments methods" is a link styled to be displayed as a button.

We have Setup a Terms and Conditions page and Setup a Privacy Policy page buttons for the internal actions on the checkout block page. However, they're not styled like a blue wp-admin button.

The goal is to have them as links to be styled as a blue wp-admin button that doesn't inherit any theme style:

  • Configure payment method
  • Setup a Terms and Conditions page
  • Setup a Privacy Policy page

We will now convert the Configure payment method link to a button. And later, we will convert all the above to a link styled as a button. Ticket for it: #8944

I'm adding this ticket to Global styles Epic to convert the Configure payment method link to a button, as it will need a separate PR.

@mikejolley mikejolley self-assigned this Apr 4, 2023
@mikejolley
Copy link
Member

We will now convert the Configure payment method link to a button.

I don't think we should mess with the semantics here; it is a link. What we can do is make it match the links in the inspector, where we have a small arrow icon beside a link to another admin page.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. focus: accessibility The issue/PR is related to accessibility. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
5 participants