This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix duplicated Shipping method Block on the front-end #8861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Issue: When local pickup is enabled and the shipping method's description is edited, the "Shipping method" is duplicated on the front-end - Solution: The previous regex didn't match some special characters such as ".", "!", etc. Because of that, it considers the Local Pickup toggle template to be missing and duplicate it.
The previous regex didn't account for some special characters that the user can use for a block's title or description, such as ".", "!", etc. As a result, the Block's template will be considered missing.
tarhi-saad
added
type: bug
woocommercebot
requested review from
a team and
nielslange
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
nielslange
approved these changes
Mar 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes duplicated Shipping method Block on the front end! This happens in case Local Pickup is enabled, and the "Shipping method" description is edited using some special characters such as
., !, &, etc.The cause of the issue is a regex pattern that didn't account for these special characters. As a result, if a user updates the description of the Shipping method Block, its template will be considered missing and will be duplicated!
We fixed this regex pattern in other parts of the code where we looked for the existence of a Block template.
Fixes #8576
Accessibility
prefers-reduced-motionOther Checks
Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce -> Settings -> Shipping -> Local pickup. Enable Local PickupPickup locations -> Add pickup location, and click onSave changes
5. Edit the default description of the "Shipping method" Block in the editor. Ensure it contains a special character (e.g., `., !`) 6. Go to the Checkout Block page. Ensure you still have a non-duplicated "Shipping method" sectionWooCommerce Visibility
Performance Impact
Changelog