This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Display pickup location details in order confirmations #8727
Merged
mikejolley
merged 7 commits into
trunk
from
enhancement/local-pickup-order-confirmation
Mar 17, 2023
Merged
Display pickup location details in order confirmations #8727
mikejolley
merged 7 commits into
trunk
from
enhancement/local-pickup-order-confirmation
Mar 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
block: checkout
Issues related to the checkout block.
block-type: local pickup
Issues related to local pickup.
labels
Mar 14, 2023
woocommercebot
requested review from
a team and
tarhi-saad
and removed request for
a team
March 14, 2023 12:24
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: +4.61 kB (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
tarhi-saad
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @mikejolley! The test is a success! Let's 🚢 it!
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Mar 17, 2023
Is that "Go get it" coming from WC? |
@ralucaStan that's my custom defined pickup instructions. |
tarunvijwani
changed the title
Enhancement/local pickup order confirmation
Display pickup location details in order confirmations.
Mar 27, 2023
tarunvijwani
changed the title
Display pickup location details in order confirmations.
Display pickup location details in order confirmations
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: checkout
Issues related to the checkout block.
block-type: local pickup
Issues related to local pickup.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the order confirmation page and emails with some extra details about pickup when using the Local Pickup shipping method. Since the filters are used by both emails and the page, we only need a single solution.
Fixes #8246
Fixes #8245
Screenshots
Testing
User Facing Testing
WooCommerce Visibility
Changelog