This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix Global Styles Block Icon Color for Mini Cart #7762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: |
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
TypeScript Errors ReportFiles with errors: 429 🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -5 B (0%) Total Size: 975 kB
ℹ️ View Unchanged
|
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
danielwrobert
force-pushed
the
fix/minicart-global-styles-icon-color
branch
from
4c5d8f7 to
a2d28de
Compare
github-actions
bot
removed
the
status: stale
danielwrobert
force-pushed
the
fix/minicart-global-styles-icon-color
branch
from
a2d28de to
0462c5c
Compare
rubikuserbot
requested review from
a team and
kmanijak
and removed request for
a team
danielwrobert
force-pushed
the
fix/minicart-global-styles-icon-color
branch
from
0462c5c to
a697229
Compare
Having the fill attributes explicitly defined on the SVG was setting the icon to purple in unexpected cases. This also reverts the quick attempt to adjust CSS selector for a fix, as it was the incorrect approach.
danielwrobert
force-pushed
the
fix/minicart-global-styles-icon-color
branch
from
a697229 to
5cfa6b4
Compare
alexflorisca
added
the
type: enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Mini Cart icon under the Blocks list in the Global Styles customizer to be the same color as the rest of the icons in the list.
Fixes #7037
Screenshots
Testing
WooCommerce Visibility
Changelog