This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Update filter button styles #6958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: |
|
Size Change: +129 B (0%) Total Size: 868 kB
ℹ️ View Unchanged
|
albarin
force-pushed
the
update/apply-filter-button-size
branch
from
1a951a0 to
0fefbce
Compare
rubikuserbot
requested review from
a team and
Aljullu
and removed request for
a team
Aljullu
reviewed
Aug 22, 2022
There was a problem hiding this comment.
Thanks for making this change and putting so much effort on getting everything look perfect. I left some comments below about using SCSS mixins when possible.
Besides that, from the PR description, shouldn't WooCommerce Visibility be WooCommerce Core? When this PR is merged, it will end up being visible in WC core as well, right?
Aljullu
approved these changes
Aug 23, 2022
Co-authored-by: Albert Juhé Lluveras <[email protected]>
|
Thanks! Looks so much better @albarin ! We can decrease the vertical spacing slightly - like this:
And the width of the inputs for this block could be reduced slightly as well!
|
|
Thanks, @vivialice, just pushed the changes! |
tarhi-saad
added
block: filter by price
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the filter
Applybuttons to match the new designs.Screenshots
Testing
All Productsblock and the filter pattern containing all filter blocks.Afterscreenshot on the editor and the frontend.WooCommerce Visibility
Changelog