This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Active Filters block: Clear All button work with all types of permalink settings. #6315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
albarin
and removed request for
a team
dinhtungdu
added
status: needs review
type: bug
|
Size Change: +42 B (0%) Total Size: 869 kB
ℹ️ View Unchanged
|
tjcafferkey
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
This change works as expected. Although I may have found an unrelated bug:
With the Plain permalink option active. Can you check if the Filter by Attribute block is working as expected when there are some active Filter by Price and Filter by Stock filters?
This is an unrelated bug to this PR, and we may need to create a separate issue for this.
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
It's working for me. Can you share the reproduce steps? But I found another issue: after choosing an attribute, the page reloads two times instead of one. This doesn't relate to the permalink setting. Screen.Recording.2022-04-26.at.16.14.03.mov |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6306
This PR updates the Clear All button to not simply redirector to the base URL. Instead, the Clear All button now removes only query args related to product filters. This makes the Clear All button work with plain URLs.
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
Plain.User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).