This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
tomasztunik
and removed request for
a team
April 15, 2022 02:27
dinhtungdu
added
status: needs review
type: bug
The issue/PR concerns a confirmed bug.
focus: i18n
The issue/PR is related to internationalization.
type: good first issue
The issue is a good candidate for the first community contribution/for a newcomer to the team.
block: mini-cart
Issues related to the Mini-Cart block.
labels
Apr 15, 2022
Size Change: +48 B (0%) Total Size: 863 kB
ℹ️ View Unchanged
|
tomasztunik
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice little fix! tested with Hebrew and looks good 👌 E2E errors are unrelated 😠
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Apr 20, 2022
This was referenced Jul 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: mini-cart
Issues related to the Mini-Cart block.
focus: i18n
The issue/PR is related to internationalization.
type: bug
The issue/PR concerns a confirmed bug.
type: good first issue
The issue is a good candidate for the first community contribution/for a newcomer to the team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6258
This PR adds RTL support for the Mini Cart icon by flipping the icon horizontally.
Screenshots
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
Changelog