Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Icon in Mini Cart button should be switched horizontally in RTL languages #6258

Closed
Aljullu opened this issue Apr 14, 2022 · 0 comments · Fixed by #6264
Closed

Icon in Mini Cart button should be switched horizontally in RTL languages #6258

Aljullu opened this issue Apr 14, 2022 · 0 comments · Fixed by #6264
Assignees
@dinhtungdu
Labels
block: mini-cart Issues related to the Mini-Cart block. focus: i18n The issue/PR is related to internationalization. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Apr 14, 2022

To reproduce

  1. Install a block theme (ie: TT2) and go to Appearance > Editor.
  2. Add the Mini Cart block to your header.
  3. Set your language to a RTL language (ie: Arabic).
  4. Go to the frontend of your site and notice the Mini Cart button looks broken.

imatge

Expected behavior

The easiest solution is probably to switch the icon horizontally?
@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. focus: i18n The issue/PR is related to internationalization. block: mini-cart Issues related to the Mini-Cart block. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. labels Apr 14, 2022
@dinhtungdu dinhtungdu self-assigned this Apr 15, 2022
@dinhtungdu dinhtungdu mentioned this issue Apr 15, 2022
Merged
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dinhtungdu dinhtungdu

Labels
block: mini-cart Issues related to the Mini-Cart block. focus: i18n The issue/PR is related to internationalization. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mini Cart: Support RTL languages woocommerce/woocommerce-blocks
2 participants
@Aljullu @dinhtungdu