This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
E2E tests for Product Category Template and Legacy Block #5820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add function to wait for Gutenberg canvas * Add alternative ids
Also: * refactors the function to add a custom paragraph for later. * updates obsolete snapshot
…t-archive # Conflicts: # tests/e2e/specs/backend/site-editing-templates.test.js # tests/e2e/utils.js
rubikuserbot
requested review from
a team and
dinhtungdu
and removed request for
a team
February 11, 2022 23:35
Size Change: 0 B Total Size: 817 kB ℹ️ View Unchanged
|
10 tasks
sunyatasattva
added
focus: FSE
Work related to prepare WooCommerce for FSE.
category: tests
skip-changelog
PRs that you don't want to appear in the changelog.
focus: template
Related to API powering block template functionality in the Site Editor
labels
Feb 18, 2022
Renamed to `visitTemplateAndAddCustomParagraph`
tomasztunik
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
This was referenced Feb 21, 2022
tarhi-saad
pushed a commit
that referenced
this pull request
Feb 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
focus: FSE
Work related to prepare WooCommerce for FSE.
focus: template
Related to API powering block template functionality in the Site Editor
skip-changelog
PRs that you don't want to appear in the changelog.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds E2E tests for the Product Category Template
Specifically, it covers the following test cases:
Closes #5657
Note that, as opposed to #5722, where I opted not to test the functionality of both the template and the block (I tested only the template-related functionality, see discussion there), here I also tested the frontend part for the block itself, due to the fact that the test was fairly simply and straightforward to write.
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
npm i
when you pull, as there is a requirement for the neweste2e-test-utils
.npm run test:e2e -- -i "tests/e2e/specs/backend/site-editing-templates.test.js"
andnpm run test:e2e -- -i "tests/e2e/specs/frontend/legacy-template-blocks.test.js"
.User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).