This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
E2E tests for Product Tag Template and Legacy Block #5888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add function to wait for Gutenberg canvas * Add alternative ids
Also: * refactors the function to add a custom paragraph for later. * updates obsolete snapshot
…t-archive # Conflicts: # tests/e2e/specs/backend/site-editing-templates.test.js # tests/e2e/utils.js
sunyatasattva
added
focus: FSE
rubikuserbot
requested review from
a team and
gigitux
and removed request for
a team
sunyatasattva
added
category: tests
skip-changelog
|
Size Change: 0 B Total Size: 817 kB ℹ️ View Unchanged
|
|
We have an issue with E2E tests setup - when testing locally tests failed around 404 and not being able to access resource and I can see the same errors here but for some reason the tests are reported as passing. inspect here -> https://github.com/woocommerce/woocommerce-gutenberg-products-block/runs/5241739163?check_suite_focus=true#step:11:62 |
|
I have mentioned it privately, but worth mentioning here too: Regarding the resource not found error, it does not stop the tests from succeeding and I have not introduced the error. In fact it's there in Gutenberg tests too! In fact they were noticed by @nielslange too about a month ago as he was working on tests (p1643628209016109/1643628203.799889-slack-C02UBB1EPEF). It's annoying and worth looking into, but not within the scope of this PR. |
Renamed to `visitTemplateAndAddCustomParagraph`
tarhi-saad
pushed a commit
that referenced
this pull request
Feb 26, 2022
Also: * Add fixtures for tags * Teardown both categories and tags when tests are done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds E2E tests for the Product Tag Template
Specifically, it covers the following test cases:
Closes #5659
Note that, as opposed to #5722, where I opted not to test the functionality of both the template and the block (I tested only the template-related functionality, see discussion there), here I also tested the frontend part for the block itself, due to the fact that the test was fairly simply and straightforward to write.
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
npm iwhen you pull, as there is a requirement for the neweste2e-test-utils.npm run test:e2e -- -i "tests/e2e/specs/backend/site-editing-templates.test.js" -t "Product Tag block template"andnpm run test:e2e -- -i "tests/e2e/specs/frontend/legacy-template-blocks.test.js" -t "Product Tag block".User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).