Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Disable font-size for the Featured Category block #5681 #5682

Merged
merged 1 commit into from
Jan 31, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions assets/js/blocks/featured-category/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@ registerBlockType( 'woocommerce/featured-category', {
align: [ 'wide', 'full' ],
html: false,
color: true,
typography: {
fontSize: true,
},
...( isFeaturePluginBuild() && {
__experimentalBorder: {
color: true,
Expand Down
5 changes: 1 addition & 4 deletions assets/js/blocks/featured-category/style.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.wp-block-woocommerce-featured-category {
background-color: #000;
background-color: $gray-900;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, this change is unrelated to this fix, right? You are setting the background color to how it was before #5542, correct?

LGTM but just wanted to make sure I'm understanding it. 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I noticed the difference and I fixed it! 👍

border-color: transparent;
color: #fff;
overflow: hidden;
Expand Down Expand Up @@ -70,7 +70,6 @@
.wc-block-featured-category__price,
.wc-block-featured-category__link {
color: inherit;
font-size: inherit;
width: 100%;
padding: 0 48px 16px 48px;
z-index: 1;
Expand All @@ -81,7 +80,6 @@

div {
color: inherit;
font-size: inherit;
}

&::before {
Expand All @@ -91,7 +89,6 @@

.wc-block-featured-category__description {
color: inherit;
font-size: inherit;
p {
margin: 0;
}
Expand Down