This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Disable font-size for the Featured Category block #5681 #5682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable font-size for the Featured Category block
gigitux
added
type: bug
|
Size Change: -22 B (0%) Total Size: 745 kB
ℹ️ View Unchanged
|
gigitux
added
the
skip-changelog
Aljullu
approved these changes
Jan 31, 2022
| @@ -1,5 +1,5 @@ | |||
| .wp-block-woocommerce-featured-category { | |||
| background-color: #000; | |||
| background-color: $gray-900; | |||
There was a problem hiding this comment.
Just to confirm, this change is unrelated to this fix, right? You are setting the background color to how it was before #5542, correct?
LGTM but just wanted to make sure I'm understanding it. 😄
There was a problem hiding this comment.
Yes, I noticed the difference and I fixed it! 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of the font size with the Global Styles API has changed the default design of the Featured Category block.
This PR disables the possibility to change the font size with the Global Styles API and restore the old and correct default design.
Fixes #5681
Screenshots
Featured Category Block using the TT1 Block Theme with the correct default design
Testing
Manual Testing
How to test the changes in this Pull Request:
Check out this branch
Feature CategoryBlock.