Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fix Mini Cart Edit template link #5615

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Fix Mini Cart Edit template link #5615

merged 1 commit into from
Jan 27, 2022

Conversation

dinhtungdu
Copy link
Member

Fixes #5580

In #5519, we update the template slug from woocommerce to woocommerce/woocommerce. The Mini Cart block still uses the old slug, that's why the edit template part link is currently broken. This PR fix that issue by using the correct theme slug.

Screenshots

N/A. No visual change.

Testing

Automated Tests

  • Changes in this PR are covered by Automated Tests.
    • Unit tests
    • E2E tests

Manual Testing

How to test the changes in this Pull Request:

  1. Add Mini Cart block to a page.
  2. Select the Mini Cart block, toggle the sidebar if needed, click on the Edit template part link.
  3. See the correct template part is loaded as expected.

User Facing Testing

These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).

  • Same as above, or
  • See steps below.

@dinhtungdu dinhtungdu added status: needs review type: bug The issue/PR concerns a confirmed bug. skip-changelog PRs that you don't want to appear in the changelog. block: mini-cart Issues related to the Mini-Cart block. labels Jan 23, 2022
@dinhtungdu dinhtungdu self-assigned this Jan 23, 2022
@rubikuserbot rubikuserbot requested review from a team and gigitux and removed request for a team January 23, 2022 12:38
Copy link
Contributor

@gigitux gigitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@github-actions github-actions bot added this to the 6.9.0 milestone Jan 27, 2022
@dinhtungdu dinhtungdu merged commit 9d4ab23 into trunk Jan 27, 2022
@dinhtungdu dinhtungdu deleted the fix/5580 branch January 27, 2022 13:47
opr added a commit that referenced this pull request Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: mini-cart Issues related to the Mini-Cart block. skip-changelog PRs that you don't want to appear in the changelog. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mini Cart: 'Edit template part' link doesn't work
2 participants