This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Update WooCommerce plugin slug for Block Templates #5519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjcafferkey
added
type: bug
rubikuserbot
requested review from
a team and
gigitux
and removed request for
a team
|
Size Change: 0 B Total Size: 819 kB ℹ️ View Unchanged
|
Aljullu
approved these changes
Jan 7, 2022
There was a problem hiding this comment.
This is testing well and code looks good, thanks for investigating @tjcafferkey!
If the site has DB entries using the old slug and the new slug:
We will have to find theterm_idfor the old slug and update all entries using it to use the new slugsterm_id.If the site has DB entries just using the old slug:
We can simply update the old slug row inwp_terms
To help me understand the urgency of this: with your fix in this PR, we are reading templates from the old and the new slugs, right? If that's the case, my understanding is that the database migration is not be really urgent, correct? It would just be a clean-up so we don't need to account for the old slug in new code we write, but that's all. Am I right?
tjcafferkey
added
the
skip-changelog
Yeah that is correct @Aljullu. It's no longer as urgent and likely won't effect that many sites assuming the feature isn't widely adopted yet. I will merge this, and create a new issue about this migration and reference this PR and the original issue for context. Thanks for testing! |
tjcafferkey
added a commit
that referenced
this pull request
Jan 17, 2022
frontdevde
added a commit
that referenced
this pull request
Jan 18, 2022
* Empty commit for release pull request * Query legacy and correct plugin slug for WooCommerce block templates (#5519) * Update readme.txt for 6.5.2 changelog * Add testing notes for 6.5.2 * Update testing instructions * Update version to 6.5.2-dev * Update testing zip for 6.5.2 * Bumping version strings to new version. Co-authored-by: github-actions <[email protected]> Co-authored-by: Tom Cafferkey <[email protected]> Co-authored-by: Michael P. Pfeiffer <[email protected]>
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the correct WooCommerce plugin slug
woocommerce/woocommerceinstead of the current incorrect onewoocommerce. However, we are maintaining the old slug until we deploy a migration script to update the DB entires.Consequences of this approach
If the site has DB entries using the old slug and the new slug:
We will have to find the
term_idfor the old slug and update all entries using it to use the new slugsterm_id.If the site has DB entries just using the old slug:
We can simply update the old slug row in
wp_termsFrom:
name:
WooCommerceslug:
woocommerceTo:
name:
woocommerce/woocommerceslug:
woocommerce-woocommerceFixes #5423
Fixes #5327
Testing
How to test the changes in this Pull Request:
Note: This is mostly regression testing.
archive-product.htmltemplate in your theme and ensure this overrides the default one provided by WooCommerce. Check this also renders correctly on the frontend and within the site editor.archive-product.htmlprovided by your theme, ensure on the Site Editor > Templates list you are still seeing the customised template in this list and it renders correctly on the frontend, and in site editor.archive-product.htmltemplate to ensure this works correctly.Performance Impact
We are querying both the old and the new slugs for customised templates which have been saved in the database. This will be resolved later using a migration script described above in this PR.