This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add Shopping Button Inner block #5614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinhtungdu
added
status: needs review
type: bug
rubikuserbot
requested review from
a team and
frontdevde
and removed request for
a team
|
Size Change: +227 B (0%) Total Size: 813 kB
ℹ️ View Unchanged
|
gigitux
suggested changes
Feb 2, 2022
|
After some investigation, I discovered that it is necessary to add this code in the template: It is necessary because, in this way, Gutenberg loads the style of buttons from theme settings. |
dinhtungdu
commented
Feb 9, 2022
templates/parts/mini-cart.html
Outdated
| <div class="wp-block-button aligncenter is-style-outline"> | ||
| <a href="/" class="wp-block-button__link">Start shopping</a> | ||
| </div> | ||
| <!-- wp:button --> |
There was a problem hiding this comment.
@gigitux Thanks for taking care of this! I think instead of using a fake button to load the core button style, we should add dedicated style for the Shopping Button block.
There was a problem hiding this comment.
The problem that I see is that every theme has a different style for the button element. In this way, we are able to have the theme style for the button.
There was a problem hiding this comment.
@gigitux If the Shopping Button block is removed then added back, the button style will be broken again because the button block markup is removed.
There was a problem hiding this comment.
This is also breaking the Site Editor:
Screen.Recording.2022-02-09.at.16.20.55.mov
There was a problem hiding this comment.
@dinhtungdu Yes! :(
How can we style the button to make it consistent with most themes? Do you have any ideas?
There was a problem hiding this comment.
I think we should keep this block simple with a basic style (square outlined button with color inherit from the parent). If users need more customization, they can replace this block by a button block.
There was a problem hiding this comment.
I can continue working on this PR if you don't mind : )
There was a problem hiding this comment.
I updated the PR, please take another look!
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
This was referenced Feb 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5582
Previously, the
Start shoppingbutton in the Mini Cart template part is a Button block with the link set to the root domain. The reason for this is: we use the template part file as the starter template for the Mini Cart Drawer, so the root domain (/) makes the most sense to be the default URL of the shopping button.This PR links the correct shop page to the shopping button by creating a new inner block that pulls the
SHOP_URLfrom the WC settings. The Shopping Button block can be moved and deleted just like a normal block.The block is styled as an outline button. The button style and alignment can't be changed. If store owners need more styling options, they should replace the block with a
Buttonblock.Screenshots
N/A. No visual change was introduced.
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).