This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Restore correct font style when the block is loaded in the editor #5600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore correct font style when the block is loaded in the editor
gigitux
added
type: bug
rubikuserbot
requested review from
a team and
sunyatasattva
and removed request for
a team
|
Size Change: +153 B (0%) Total Size: 815 kB
ℹ️ View Unchanged
|
nielslange
reviewed
Jan 20, 2022
|
Thanks for your great review! I thought that restoring these two lines should be fine. |
nielslange
approved these changes
Jan 20, 2022
gigitux
added a commit
that referenced
this pull request
Jan 20, 2022
* Empty commit for release pull request * Update readme.txt with 6.8.0 changelog * initialize_session if it does not yet exist before calling the session class (#5577) * Add testing notes for 6.8.0 * update testing release notes * update testing notes * Fix default `stockStatusOptions` in tag and attribute blocks (#5590) * Fix default stockStatusOptions in tag and attribute blocks These should be an array of keys, not objects. * Fix stockStatus definition on PHP side * Swap state to debounce. * Improve presentation of stock filters * Remove state usage for display options * Remove debounce * Consistent panel titles * Fix global style for Product Summary block, Product Stock Indicator block, and Product Title block (#5595) * Fix global style for Product Summary block, Product Stock Indicator block, and ProductTitle block Fix global style for Product Summary block, Product Stock Indicator block, and ProductTitle block * add feature flag * fix lint errors * fix global style bugs on Product Title block * update testing release notes * update new build with fixes * Restore correct font style when the block is loaded in the editor (#5600) * Restore correct font style when the block is loaded in the editor Restore correct font style when the block is loaded in the editor * fix style on Twenty Twenty theme * update link for download the zip of the new release * update readme.txt * Bumping version strings to new version. Co-authored-by: github-actions <[email protected]> Co-authored-by: Luigi <[email protected]> Co-authored-by: Mike Jolley <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5595 has introduced a different font style for the
Product Title blockwhen theAll Product blockis loaded in the editor.This PR restores the correct font style.
Screenshots
#5595 introduce a different font style from our current style
this PR restores the correct style
How to test the changes in this Pull Request:
WordPress 5.9.Twenty Twenty-Twotheme.All Product Block(this block containsProduct Title block) to a post. Check that the font style looks like the second image.Product Title block.Product Title block.Stylesicon on the right-top corner.Product Title blockis shown under theBlockssection. Personalize the block.