This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix default stockStatusOptions in tag and attribute blocks
#5590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should be an array of keys, not objects.
mikejolley
added
status: needs review
status: blocker
rubikuserbot
requested review from
a team and
nielslange
and removed request for
a team
|
Size Change: -2.65 kB (0%) Total Size: 815 kB
ℹ️ View Unchanged
|
senadir
reviewed
Jan 18, 2022
senadir
reviewed
Jan 18, 2022
senadir
reviewed
Jan 18, 2022
senadir
reviewed
Jan 18, 2022
nielslange
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
Functionality-wise, the PR works as expected.
Not directly related to this PR, but I noticed that we're using two different labels for the same functionality. Do you think it's worth to add this minor fix to this PR or shall I create a separate issue for that?
|
Stock level
|
Filter by stock status
|
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
|
@nielslange I changed that too, want to look again or good to go? |
gigitux
approved these changes
Jan 19, 2022
gigitux
pushed a commit
that referenced
this pull request
Jan 19, 2022
* Fix default stockStatusOptions in tag and attribute blocks These should be an array of keys, not objects. * Fix stockStatus definition on PHP side * Swap state to debounce. * Improve presentation of stock filters * Remove state usage for display options * Remove debounce * Consistent panel titles
Sorry, @mikejolley. I missed your comment and @gigitux was too fast with merging. All good, though. Thanks for considering that change. 🙌 |
gigitux
added a commit
that referenced
this pull request
Jan 20, 2022
* Empty commit for release pull request * Update readme.txt with 6.8.0 changelog * initialize_session if it does not yet exist before calling the session class (#5577) * Add testing notes for 6.8.0 * update testing release notes * update testing notes * Fix default `stockStatusOptions` in tag and attribute blocks (#5590) * Fix default stockStatusOptions in tag and attribute blocks These should be an array of keys, not objects. * Fix stockStatus definition on PHP side * Swap state to debounce. * Improve presentation of stock filters * Remove state usage for display options * Remove debounce * Consistent panel titles * Fix global style for Product Summary block, Product Stock Indicator block, and Product Title block (#5595) * Fix global style for Product Summary block, Product Stock Indicator block, and ProductTitle block Fix global style for Product Summary block, Product Stock Indicator block, and ProductTitle block * add feature flag * fix lint errors * fix global style bugs on Product Title block * update testing release notes * update new build with fixes * Restore correct font style when the block is loaded in the editor (#5600) * Restore correct font style when the block is loaded in the editor Restore correct font style when the block is loaded in the editor * fix style on Twenty Twenty theme * update link for download the zip of the new release * update readme.txt * Bumping version strings to new version. Co-authored-by: github-actions <[email protected]> Co-authored-by: Luigi <[email protected]> Co-authored-by: Mike Jolley <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with the default value of
stockStatusOptionsin theProducts by AttributeandProducts by tagblocks which causes a block error when using the stock filter.We need an array of keys, rather than objects. This PR fixes this.
Additionally, in testing we found some strange issues where preview state did not match selections. This is in part a UI issue but to improve this I've:
Testing
How to test the changes in this Pull Request:
Products by Attributeblockstock statuscontrol in the inspectorProducts by tagFor the blocks, also check:
cc @gigitux