Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

#4625 fixing product categories list block display #4913

Closed

Conversation

ovidiul
Copy link
Contributor

@ovidiul ovidiul commented Oct 7, 2021

This PR fixes #4625 product categories list block display by HTML encoding the minus sign, which is the hierarchy prefix.

Fixes #4625

Accessibility

Screenshots

Screenshot 2021-10-07 at 14 29 24

Testing

Automated Tests

  • Changes in this PR are covered by Automated Tests.
    • Unit tests
    • E2E tests

Manual Testing

How to test the changes in this Pull Request:

  1. Create 4 WooCommerce product categories, each one nested under the previous one created, like follows:
  • Level 1
    • Level 2
      • Level 3
        • Level 4
  1. Add a product to the last category
  2. To a page, add the block Product Categories List
  3. Under the block settings > List settings > Display style, pick "Dropdown"
  4. Again under the block settings > Content, switch On "Show hierarchy"
  5. Save and view page

Performance Impact

Changelog

fixed the Product Category List Block frontend hierarchy display by HTML encoding the hierarchy prefix

@senadir
Copy link
Member

senadir commented Oct 8, 2021

How does this #4905 relate to this PR?

@ovidiul ovidiul changed the title #1682 fixing product search accesibility label #4625 fixing product categories list block display Oct 8, 2021
@ovidiul
Copy link
Contributor Author

ovidiul commented Oct 8, 2021

It doesn't, should be fixed now, thanks for noticing that.

@ovidiul
Copy link
Contributor Author

ovidiul commented Oct 8, 2021

Will clean up the commit and re-open a new one.

@ovidiul ovidiul closed this Oct 8, 2021
@ralucaStan
Copy link
Contributor

This is the new PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Woo Product Categories List not visually differentiating between Level 3 and Level 4 categories
4 participants