This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product categories list block hierarchy display fix #4920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
I've tested this PR and it works as expected. |
Sure, its done now, however I think its failing for external reasons to the code, seeing this at the Linting step: |
|
Seems I've added another non-related commit in there, fixing that in a moment. |
ovidiul
force-pushed
the
fix_product_cat_list_display
branch
from
9a4d01a to
c9570c0
Compare
ovidiul
force-pushed
the
fix_product_cat_list_display
branch
from
da2ff4d to
397a908
Compare
|
Non-related commit fixed, as per my previous reply, JavaScript Linting fails with: |
|
Merging this as the failed |
opr
pushed a commit
that referenced
this pull request
Oct 12, 2021
opr
added a commit
that referenced
this pull request
Oct 12, 2021
* Empty commit for release pull request * Update readme.txt with release changelog * Add testing instructions for 6.1.0 release * Update readme.txt with release changelog * #4625 product categories list block hierarchy display fix (#4920) * Update link to testing zip * Remove mini cart testing from instructions This is because mini-cart is only in experimental builds. * Update changelog and testing notes * Correct typo in testing instructions * Update testing instructions * Bumping version strings to new version. Co-authored-by: github-actions <[email protected]> Co-authored-by: Thomas Roberts <[email protected]> Co-authored-by: Ovidiu Liuta <[email protected]>
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
* Empty commit for release pull request * Update readme.txt with release changelog * Add testing instructions for 6.1.0 release * Update readme.txt with release changelog * woocommerce#4625 product categories list block hierarchy display fix (woocommerce#4920) * Update link to testing zip * Remove mini cart testing from instructions This is because mini-cart is only in experimental builds. * Update changelog and testing notes * Correct typo in testing instructions * Update testing instructions * Bumping version strings to new version. Co-authored-by: github-actions <[email protected]> Co-authored-by: Thomas Roberts <[email protected]> Co-authored-by: Ovidiu Liuta <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4625 product categories list block display by HTML encoding the minus sign, which is the hierarchy prefix.
Fixes #4625
Accessibility
prefers-reduced-motionScreenshots
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
Performance Impact
Changelog