-
Notifications
You must be signed in to change notification settings - Fork 219
Refactor default editing state for customer address fields #11765
Conversation
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: -93 B (0%) Total Size: 1.58 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and tested well, nice one! I've added a couple of labels to the PR and ticked the "has label" checkbox as it was empty. Good to go...except for the conflicting files with trunk, if you update that, I'll take another quick look 👍
86b5db1
to
b2a1116
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now, thanks 👍
What
Fixes the default editing state of the address fields so that:
Fixes #11726
Why
Editing should be true in the editor so changes to fields are visible.
Testing Instructions
Please test all cases in at least Chrome and Firefox, since Firefox behaviour can differ.
Please consider any edge cases this change may have, and also other areas of the product this may impact.
WooCommerce Visibility
Required:
Checklist
Required:
[type]
label or a[skip-changelog]
label.Conditional:
[skip-changelog]
label is not present).Changelog