This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Update wording on checkout error message to try to prevent retries #10888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
added
status: needs review
type: enhancement
woocommercebot
requested review from
a team and
tarhi-saad
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +253 B (0%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
|
@opr are we sure the email is sent at this point if the order is placed? |
@ralucaStan We're not sure that the email has been sent at this point, that's the issue. The fail could have happened at any point in the checkout process, so we don't know if the order was successful or not, the idea of this PR is to get the user to double check if the order placed before retrying to prevent double orders.
Yes, actually we could, if the |
ralucaStan
suggested changes
Sep 22, 2023
| @@ -293,12 +295,20 @@ const CheckoutProcessor = () => { | |||
| __internalProcessCheckoutResponse( response ); | |||
| } ); | |||
| } catch { | |||
| let errorMessage = __( | |||
| 'Something went wrong, but your order may still have been placed. Please check your email inbox before retrying.', | |||
There was a problem hiding this comment.
Something went wrong when placing the order. Check your email for order updates before retrying.
|
|
||
| if ( customerId !== 0 ) { | ||
| errorMessage = __( | ||
| 'Something went wrong, but your order may still have been placed. Please check your email inbox or your order history in the "My Account" area before retrying.', |
There was a problem hiding this comment.
Something went wrong when placing the order. Check your account's order history for order updates before retrying.
There was a problem hiding this comment.
I think we should still include email here, but otherwise fine. Let me update them.
opr
force-pushed
the
update/error-checkout-wording
branch
from
8a93992 to
ffdd46c
Compare
|
Bumping the PR to the next release |
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
github-actions
bot
removed
the
status: stale
|
Bumping PR to next release. |
ralucaStan
approved these changes
Oct 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR updates the error message on the Checkout block that's displayed if an error is encountered during processing. It recommends the user checks their email or My Account area before retrying to prevent duplicate orders.
Partially solves woocommerce/woocommerce#42223, however we will keep that open until a more robust solution is in place.
Why
Some shoppers would continually retry their order when seeing this error as it's unclear that the order was placed.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog