-
Notifications
You must be signed in to change notification settings - Fork 219
Conversation
The release ZIP for this PR is accessible via:
Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
$this->package->set_version_stored_on_db(); | ||
} | ||
// This is just a temporary solution to make sure the migrations are run. We have to refactor this. More details: https://github.com/woocommerce/woocommerce-blocks/issues/10196. | ||
if ( $this->package->get_version() !== $this->package->get_version_stored_on_db() ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting here that on every page get_version_stored_on_db()
will run get_option()
. There was conversations around performance but given that this is a temporary fix, and that get_option()
has caching this was a trade off we were willing to temporarily take.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go. Thanks @gigitux !
* Empty commit for release pull request * Stop reading Product IDs from asset store in filter blocks (#10195) * Remove queries that fetch all products for manipulating the results returned by the Store API for certain use-cases. * Remove the code that's supposed to read product ids for filter context and logic around that in useCollectionData * Fix incorrect merge --------- Co-authored-by: Patricia Hillebrandt <[email protected]> * fix migration (#10205) * Add cherry picked PRs and add testing link * Cherry pick aa9312d and resolve conflict for version 10.4.6 as the add_support_for_filter_blocks function was introduced in an older version (10.6) * Merge pull request from GHSA-gxfx-93xq-pr6p * Add cors check * refactor logic * Refactor add_cors_headers to allow null and allowed hosts * Move remove_filter inline * Revert unrelated code style changes * Add explainer to docblock * Remove access for null origin * Move CORS handling to auth class so it applies API wide * Move only Authentication to priority 11 * Handle preflight requests so cart-tokens work --------- Co-authored-by: Mike Jolley <[email protected]> * Add testing notes * Add testing zip to notes * Add changelog to readme * Update version numbers * Update testing zip * Replace sanitization functions to enforce string values (#10242) * Update testing zip * Update testing zip --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Karol Manijak <[email protected]> Co-authored-by: Patricia Hillebrandt <[email protected]> Co-authored-by: Luigi Teschio <[email protected]> Co-authored-by: Thomas Roberts <[email protected]> Co-authored-by: Seghir Nadir <[email protected]> Co-authored-by: Mike Jolley <[email protected]>
* Empty commit for release pull request * Product Filters > Fix Performance issue and Fatal error on stores with a high volume of products (#10198) * Remove queries that fetch all products for manipulating the results returned by the Store API for certain use-cases. * Keep support for Product Collection block * Stop reading Product IDs from asset store in filter blocks (#10195) * Remove queries that fetch all products for manipulating the results returned by the Store API for certain use-cases. * Remove the code that's supposed to read product ids for filter context and logic around that in useCollectionData * Fix incorrect merge --------- Co-authored-by: Patricia Hillebrandt <[email protected]> * Add testing instructions for 10.6.1 * Fix margin issue with the Proceed to checkout button on the site editor (#10182) * Fix margin issue with the Proceed to checkout button on the site editor * Remove unecessary selector * Merge pull request from GHSA-gxfx-93xq-pr6p * Add cors check * refactor logic * Refactor add_cors_headers to allow null and allowed hosts * Move remove_filter inline * Revert unrelated code style changes * Add explainer to docblock * Remove access for null origin * Move CORS handling to auth class so it applies API wide * Move only Authentication to priority 11 * Handle preflight requests so cart-tokens work --------- Co-authored-by: Mike Jolley <[email protected]> * Add changelog to readme * Bump versions, readme, changelog, and testing notes * Add testing zip * fix migration (#10205) * New testing zip * Don't send headers early in Store API (#10241) * Replace sanitization functions to enforce string values (#10242) * New testing zip * Update changelog --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Patricia Hillebrandt <[email protected]> Co-authored-by: Karol Manijak <[email protected]> Co-authored-by: Thomas Roberts <[email protected]> Co-authored-by: Alex Florisca <[email protected]> Co-authored-by: Seghir Nadir <[email protected]> Co-authored-by: Mike Jolley <[email protected]> Co-authored-by: Luigi Teschio <[email protected]>
This PR is a partial fix for woocommerce/woocommerce#42300. This PR removes the check
is_admin
, so the logic that checks the version and runs the migration is also run on the front end.Partial Fixes woocommerce/woocommerce#42300
installing plugin from uploaded file
screen.WooCommerce Visibility