This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix margin issue with the Proceed to checkout button on the site editor #10182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
opr
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +48 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
opr
approved these changes
Jul 12, 2023
opr
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
'm wondering if using
$gap-largerwould be better than using the pixel value? Not super sure on that one so just checking to see if you thought about it.
Never mind, I think this is fine, if the classic editor specifically adds 28px we should keep it.
Approved! 🚀
alexflorisca
added
release: cherry-pick
opr
removed
the
release: cherry-pick
|
Removed the |
opr
pushed a commit
that referenced
this pull request
Jul 17, 2023
…or (#10182) * Fix margin issue with the Proceed to checkout button on the site editor * Remove unecessary selector
opr
added
the
release: cherry-pick
opr
added a commit
that referenced
this pull request
Jul 18, 2023
* Empty commit for release pull request * Product Filters > Fix Performance issue and Fatal error on stores with a high volume of products (#10198) * Remove queries that fetch all products for manipulating the results returned by the Store API for certain use-cases. * Keep support for Product Collection block * Stop reading Product IDs from asset store in filter blocks (#10195) * Remove queries that fetch all products for manipulating the results returned by the Store API for certain use-cases. * Remove the code that's supposed to read product ids for filter context and logic around that in useCollectionData * Fix incorrect merge --------- Co-authored-by: Patricia Hillebrandt <[email protected]> * Add testing instructions for 10.6.1 * Fix margin issue with the Proceed to checkout button on the site editor (#10182) * Fix margin issue with the Proceed to checkout button on the site editor * Remove unecessary selector * Merge pull request from GHSA-gxfx-93xq-pr6p * Add cors check * refactor logic * Refactor add_cors_headers to allow null and allowed hosts * Move remove_filter inline * Revert unrelated code style changes * Add explainer to docblock * Remove access for null origin * Move CORS handling to auth class so it applies API wide * Move only Authentication to priority 11 * Handle preflight requests so cart-tokens work --------- Co-authored-by: Mike Jolley <[email protected]> * Add changelog to readme * Bump versions, readme, changelog, and testing notes * Add testing zip * fix migration (#10205) * New testing zip * Don't send headers early in Store API (#10241) * Replace sanitization functions to enforce string values (#10242) * New testing zip * Update changelog --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Patricia Hillebrandt <[email protected]> Co-authored-by: Karol Manijak <[email protected]> Co-authored-by: Thomas Roberts <[email protected]> Co-authored-by: Alex Florisca <[email protected]> Co-authored-by: Seghir Nadir <[email protected]> Co-authored-by: Mike Jolley <[email protected]> Co-authored-by: Luigi Teschio <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug with the Proceed to Checkout button on the Cart block, where it looses its margins, only in the site editor. The reason being that for the classic block editor, the stylesheet ads a 28px border around every wp block.
This doesn't apply to the site editor so the Proceed to Checkout button looses its margins. The solution here is to explicitly set the margins on the Proceed to Checkout button so that it keeps them on both the site editor and the classic block editor.
Partly Fixes #10177
Accessibility
prefers-reduced-motionScreenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Changelog