Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Checkout step titles and descriptions show a white on white in dark themes in the editor. #7007

Closed
senadir opened this issue Aug 30, 2022 · 0 comments · Fixed by #8380
Closed
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@senadir
Copy link
Member

senadir commented Aug 30, 2022

In the editor, if you have a theme with a dark background, Checkout steps title and descriptions will show white text on white background.

This issue also exists for Cart block.

This is because we're using PlainText component which renders a textarea with a white background, and while the text renders the correct color (white), the background is still white.

image
image
image

How to reproduce

  • Load up a theme with a possible dark background, like 2022 FSE.
  • Load Checkout block.
  • Switch to "use dark inputs" to remove false positives.
  • See the broken text inputs.

Expected outcome

Fields should have no background to match the final UI.

Possible fixes

One fix is to force transparent background for all of those text areas, this is a blunt quick solution. Mainly to the .block-editor-plain-text selector.

Preferred solution is to switch to using RichText instead of PlainText. RichText can be tweaked to disble certain features like links and italic/bold text, but it will benefit from opt in to global styles like colors, sizes, and better customization, I'd love if we can spike this.

@senadir senadir added type: bug The issue/PR concerns a confirmed bug. block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. labels Aug 30, 2022
@ralucaStan ralucaStan added the type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. label Aug 30, 2022
mikejolley added a commit that referenced this issue Feb 7, 2023
* Switch default cart headings for cross sells to h2/h3

Fixes #8193

* Style empty cart icon

#8360

* Ensure editable content fields are transparent in the editor

#8359 #7007
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants