Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Support Editing Place Order button text in Checkout editor page. #7015

Closed
senadir opened this issue Aug 30, 2022 · 1 comment · Fixed by #7843
Closed

Support Editing Place Order button text in Checkout editor page. #7015

senadir opened this issue Aug 30, 2022 · 1 comment · Fixed by #7843
Labels
block: checkout Issues related to the checkout block. type: enhancement The issue is a request for an enhancement.

Comments

@senadir
Copy link
Member

senadir commented Aug 30, 2022

Like #7012, The Place Order button doesn't support custom text directly, however, between all of them, this button is the most delicate because it is programmatically editable by a payment method, and we will make it editable via a filter.

image

Priority of text

Text should be shown with priority (first being the most important):

  • The value returned by a filter (Matters if this issue Support dynamic place order button label #5876 is closed before working on this one).
  • The value returned by a payment method.
  • The value persisted by the merchant (this issue).
  • The default value "Proceed to checkout" and i18n versions.

Expected outcome

  • You should be able to select the button and edit the text with no styling options.
    A greater option would be to reuse the Button block or the button component or mimic that.

This should set the road to have full global styles support for that button, but that's a future goal.

A reminder to not fall into #7007 again is that we should mimic Button block and use RichText instead of PlainText.

Related issues

@senadir senadir added type: enhancement The issue is a request for an enhancement. block: checkout Issues related to the checkout block. labels Aug 30, 2022
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Oct 30, 2022
@nielslange nielslange removed the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: checkout Issues related to the checkout block. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants