Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Price slider: prices are read without accounting currency minorUnit value #1657

Closed
Aljullu opened this issue Jan 28, 2020 · 1 comment
Closed
Labels
block: filter by price Issues related to the Filter by Price block. focus: accessibility The issue/PR is related to accessibility. status: stale Stale issues and PRs have had no updates for 60 days. type: bug The issue/PR concerns a confirmed bug.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Jan 28, 2020

imatge

To Reproduce

  1. Set your store to use a currency where minorUnit is bigger than 0, for example US Dollars or Euros.
  2. Create a post with the All Products and the Price Filter blocks.
  3. In Price Filter block options, select Price Range > Text.
  4. In the frontend and with a screen reader, navigate to the price slider.
  5. Notice values are read without accounting for the currency minorUnit value. For example, if the price is €10-€90 screen reader reads 1000-9000.

Expected behavior
The screen reader should read the correct value, not the value used internally by the price slider (so €10 instead of 1000).

@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. focus: accessibility The issue/PR is related to accessibility. labels Jan 28, 2020
@nerrad nerrad added the block: filter by price Issues related to the Filter by Price block. label Jun 7, 2020
@mikejolley mikejolley self-assigned this Jun 25, 2020
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

######Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: filter by price Issues related to the Filter by Price block. focus: accessibility The issue/PR is related to accessibility. status: stale Stale issues and PRs have had no updates for 60 days. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants