Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Knobs on "Filter by price" do not have the correct screen-reader text #4378

Closed
opr opened this issue Jun 21, 2021 · 1 comment · Fixed by #4839
Closed

Knobs on "Filter by price" do not have the correct screen-reader text #4378

opr opened this issue Jun 21, 2021 · 1 comment · Fixed by #4839
Assignees
Labels
block: filter by price Issues related to the Filter by Price block. focus: accessibility The issue/PR is related to accessibility. type: bug The issue/PR concerns a confirmed bug.

Comments

@opr
Copy link
Contributor

opr commented Jun 21, 2021

Describe the bug

When using the "Filter by price" block, if you click the individual knobs with a screen reader active, it reads out the value without the decimal place. £200.00 is read out as "twenty thousand".

https://www.loom.com/share/3f32bcd3b3ee4e5c9c7d19ac3447e4d3

Seems semi-related to #1657

To reproduce

Steps to reproduce the behavior:

  1. Add the "Filter by price" block to a page
  2. Activate VoiceOver or some other screen reader.
  3. Interact with the knobs on the slider and listen to the readout, it is not correct.

Expected behavior

The screen reader text should be correct.

@opr opr added type: bug The issue/PR concerns a confirmed bug. focus: accessibility The issue/PR is related to accessibility. block: filter by price Issues related to the Filter by Price block. labels Jun 21, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Aug 21, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Aug 26, 2021
@tjcafferkey tjcafferkey self-assigned this Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: filter by price Issues related to the Filter by Price block. focus: accessibility The issue/PR is related to accessibility. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants